fix(installer): make Runtime Pack install reversible

[div0-space]

Stacked on #70. Do not merge before the base PR.

Summary

• carry the shared installer and its import closure inside the signed Runtime Pack
• make AppDelegate delegate hydration and reset to that installer
• record closed ownership receipts with hashes and collision backups
• fail closed before teardown on modified files or tampered receipt paths
• preserve Vibecrafted.app while resetting owned runtime/config/state surfaces

Verification so far

• make unified-product-contract-gate: 625 passed, 18 skipped; core 89 passed, 1 skipped; self-test PASS; wheel install PASS
• make check
• make semgrep
• unsigned Xcode Debug build
• portable build and checksum verification from c7eca02

Blacky fresh-onboarding runtime verification remains in progress; final Linux tarball smoke and PR-check observation will follow after implementation stabilizes.

[Copilot]

Pull request overview

This PR makes the signed/offline “Runtime Pack” install path reversible by embedding the shared installer (and its import closure) into the Runtime Pack, delegating native app runtime hydration/reset to that installer, and switching uninstall to a receipt-driven, fail-closed workflow.

Changes:

• Embed scripts/vetcoders_install.py + minimal import closure inside the Runtime Pack and include them in required-hash/product-contract checks.
• Add runtime-install / runtime-uninstall modes to the shared installer with a hashed ownership receipt and pre-teardown drift/tamper checks.
• Update the macOS app to call the embedded installer for install/uninstall instead of implementing install logic in Swift; adjust tests/docs to match.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
vibecrafted-core/vibecrafted_core/skills/vc-aicx/SKILL.md	Update tmp-path example to /private/tmp/claude-<uid>/… form.
vibecrafted-core/vibecrafted_core/skills/pl/vc-aicx/SKILL.md	Polish mirror of the same tmp-path example update.
vibecrafted-core/vibecrafted_core/product_contract.py	Expand runtime required-hash set to include installer/import-closure scripts.
vibecrafted-core/vibecrafted_core/deck/vibecrafted	Make uninstall prefer the Runtime Pack’s bundled Python/installer when available.
vibecrafted-core/tests/test_runtime_receipt.py	Update runtime receipt fixture/hash-count expectations for new required files.
vibecrafted-app/shell-agent/app/Vibecrafted/NotificationManager.swift	Mark as @unchecked Sendable with documentation of threading assumptions.
vibecrafted-app/shell-agent/app/Vibecrafted/AppDelegate.swift	Delegate runtime install/uninstall to embedded installer; add --uninstall flag handling.
vibecrafted-app/docs/plans/PLAN_23_AGENT_OPERATOR_DASHBOARD.md	Normalize repo/tmp path literals away from user-specific values.
tests/tui/test_uv_bootstrap.py	Add scripts/installer_brand.py to required-file checks.
tests/tui/test_unified_app_contract.py	Update assertions to ensure AppDelegate uses embedded installer; validate embedded script presence.
tests/tui/test_release_contract.py	Shift terminal-policy/entry assertions from AppDelegate to installer script.
tests/tui/test_payload_hygiene.py	Add coverage for /private/tmp handling as /tmp realpath on macOS.
tests/tui/test_keys.py	Switch wrapper-verb parity check from Swift parsing to installer constant _RUNTIME_WRAPPER_VERBS.
tests/tui/test_installer_uninstall.py	Add round-trip install/uninstall tests and fail-closed conflict/tamper coverage for receipt mode.
tests/tui/test_installer_doctor.py	Expand runtime-generation fixture sources to include embedded installer/import-closure scripts.
tests/tui/test_install_bootstrap.py	Add scripts/installer_brand.py to required-file checks.
tests/tui/test_distribution_manifest.py	Update included payload list and mutation tests to reflect new required scripts.
scripts/vibecrafted	Same change as deck copy: prefer bundled installer Python when uninstalling from a Runtime Pack generation.
scripts/vetcoders_install.py	Implement receipt-based runtime-install/runtime-uninstall, add required-hash entries, and integrate runtime-uninstall into legacy uninstall.
scripts/lib/payload-hygiene.sh	Treat /private/tmp as a generic root for topmost-host-root logic on macOS.
scripts/distribution_manifest.py	Include scripts/installer_brand.py in distribution include list.
scripts/build-vibecrafted-release.sh	Install embedded installer/import-closure scripts into the Runtime Pack at build time.
install.sh	Add scripts/installer_brand.py to the bootstrap required-file set.
docs/installer/REQUIRED-SET.md	Update docs to distinguish receipt-based Runtime Pack uninstall vs legacy discovery uninstall and list new required surfaces.

Suppressed comments (1)

scripts/vetcoders_install.py:14625

• runtime-uninstall drift detection skips any owned path that has been replaced with a symlink (or other non-regular file), so an attacker or accidental change can bypass the “fail closed before teardown” check. Treat any existing owned path that is a symlink or not a regular file as a conflict.

    conflicts = [
        raw_path
        for raw_path, installed_hash in sorted(owned_files.items())
        if (path := Path(raw_path)).is_file()
        and not path.is_symlink()
        and _sha256_path(path) != installed_hash
    ]

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.

Suppressed comments (2)

Previously missed (1) — in code that hasn't changed since the last review.

scripts/vetcoders_install.py:14803

• Conflict detection for owned_files ignores cases where an owned file has been replaced with a symlink or a non-regular file. That’s still local modification and should fail closed before teardown; otherwise uninstall will silently unlink the symlink and proceed.

        if (path := Path(raw_path)).is_file()
        and not path.is_symlink()
        and _sha256_path(path) != installed_hash
    ]

scripts/vetcoders_install.py:14590

• terminal-theme.toml is a regular file but it’s being recorded under owned_dirs, so it won’t be hash-verified for drift and can be removed without triggering the conflict fail-closed behavior. Record it as an owned_files entry (hash) instead.

    terminal_theme = product_config / "terminal-theme.toml"
    if not terminal_theme.exists():
        shutil.copy2(generation / "config/vc-terminal/themes/dark.toml", terminal_theme)
        receipt["owned_dirs"].append(str(terminal_theme))
    terminal_policy = generation / "config/vc-terminal/vibecrafted.toml"

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.

Suppressed comments (1)

scripts/vetcoders_install.py:14589

• terminal-theme.toml is recorded under owned_dirs (and not hashed), so runtime-uninstall will not detect local edits to this managed file before teardown/removal. This breaks the “fail closed on locally modified managed files” guarantee and can silently delete operator changes to the theme.

    terminal_theme = product_config / "terminal-theme.toml"
    if not terminal_theme.exists():
        shutil.copy2(generation / "config/vc-terminal/themes/dark.toml", terminal_theme)
        receipt["owned_dirs"].append(str(terminal_theme))

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.

Suppressed comments (2)

scripts/vetcoders_install.py:14589

• terminal-theme.toml is being tracked in owned_dirs, so it is not hashed and won’t be included in the modified-file conflict check during runtime-uninstall. If the operator edits the theme after install, uninstall can silently delete it instead of failing closed as intended for receipted ownership.

    terminal_theme = product_config / "terminal-theme.toml"
    if not terminal_theme.exists():
        shutil.copy2(generation / "config/vc-terminal/themes/dark.toml", terminal_theme)
        receipt["owned_dirs"].append(str(terminal_theme))

vibecrafted-app/shell-agent/app/Vibecrafted/AppDelegate.swift:356

• The app runs the bundled installer under the inherited process environment. To reduce the risk of Python environment injection (e.g., PYTHONPATH/startup hooks) when executing a signed installer, run the bundled interpreter in isolated mode.

    let process = Process()
    let output = Pipe()
    let errors = Pipe()
    process.executableURL = python
    process.arguments = [installer.path] + arguments
    var environment = ProcessInfo.processInfo.environment
    environment["PYTHONNOUSERSITE"] = "1"
    environment["PYTHONDONTWRITEBYTECODE"] = "1"
    process.environment = environment

[Copilot]

Pull request overview

Copilot reviewed 57 out of 59 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

• vibecrafted-app/shell-agent/app/Vibecrafted.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Generated file