[sairedis] Meta changes for voq system ports#1
Open
vganesan-nokia wants to merge 2 commits into
Open
Conversation
brcmnokia
reviewed
Aug 19, 2020
| REDIS_GENERIC_QUAD_ENTRY(FDB_ENTRY,fdb_entry); | ||
| REDIS_BULK_QUAD_ENTRY(FDB_ENTRY,fdb_entry); | ||
|
|
||
| // TODO remove when test corrected (SAI pointer must be advanced for this) |
There was a problem hiding this comment.
Is this file changes needed part of first PR
Owner
Author
There was a problem hiding this comment.
No. I'll remove this change from this PR
| MUTEX_UNLOCK; // explicit unlock | ||
|
|
||
| // nothing to collect, wait until notified | ||
| if (m_runFlexCounterThread) { |
Owner
Author
There was a problem hiding this comment.
This is a bug fix we made for a race condition. This is not part of the voq implementation. We observed that sometimes, orchagent will be stuck due to dead lock. This happens in our box. May not be problem with vs or other vendors. I'll remove this fix from this PR.
|
|
||
|
|
||
| // TODO remove when SAI will introduce bulk APIs to those objects | ||
| sai_status_t sai_bulk_create_fdb_entry( |
Owner
Author
There was a problem hiding this comment.
No. This is not part of voq implementation. I'll remove this change from this PR.
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes include (1) Meta layer changes for handling system port config list and system port config attributes of voq system port SAI object (2) syncd get response time increase to 5 minutes