Markpadbe branch - #8
Open
markpadbe wants to merge 7 commits into
Open
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
markpadbe
marked this pull request as draft
February 6, 2024 22:37
markpadbe
marked this pull request as ready for review
February 6, 2024 22:54
markpadbe
marked this pull request as draft
February 6, 2024 22:54
akobrina
requested changes
Feb 6, 2024
akobrina
left a comment
akobrina
left a comment
Collaborator
There was a problem hiding this comment.
Requesting change to console log message.
| console.log('blah blah'); | ||
| } | ||
|
|
||
| if (el.classList.contains('new-variant')) console.log('got it...in the new branch!'); |
Collaborator
Author
There was a problem hiding this comment.
@akobrina, Thank you. I've updated the code.
Collaborator
|
this looks good to me |
markpadbe
marked this pull request as ready for review
February 6, 2024 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-NUMBER
Test URLs: