Skip to content

Chunked conversion path silently ignores most CLI options #5

Description

@vgreg

Umbrella issue. When --input-chunk-size is passed, convert_data delegates to _handle_chunked_conversion and returns at src/daflip/services.py:575-579 before any of the other option handling runs. Several documented flags are accepted on the command line, produce no warning, and have no effect.

This is the failure mode that matters: the command exits 0 and prints "Conversion successful!", so the option looks honoured. On a large file the user only discovers otherwise much later, if at all.

Sub-issues:

  • --compression / --compression-level ignored when chunking
  • --schema-file ignored when chunking
  • --rows ignored when chunking
  • --output-chunk-size is accepted and validated but never used
  • schema command reads the entire file for non-CSV formats

A shared consideration across all of these: where an option genuinely cannot be supported in chunked mode, the CLI should fail loudly rather than proceed silently.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions