Skip to content

--schema-file is ignored when chunking #7

Description

@vgreg

Part of #5.

user_schema is loaded at src/daflip/services.py:566-568, but the chunked branch at services.py:575-579 neither receives nor uses it. The schema is read, validated, and discarded.

This also removes the natural workaround for schema-drift problems in chunked writes: a user who knows their column types cannot supply them. Related to the null-type inference bug fixed in fix-chunked-parquet-null-schema, where a user-supplied schema would have been the obvious escape hatch.

Fix: pass the schema into _handle_chunked_conversion and, when present, use it as the ParquetWriter schema and cast each chunk to it instead of inferring from the first chunk.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions