Skip to content

--rows is ignored when chunking #8

Description

@vgreg

Part of #5.

_apply_row_selection (src/daflip/services.py:410) is only called on the non-chunked path (services.py:587). With --input-chunk-size set, --rows 0:100 is accepted and the full file is converted.

Note the non-chunked path already degrades quietly here too: an unparseable --rows prints a warning and continues with the full dataset rather than erroring.

Fix: apply the row window across the chunk stream, or reject the combination explicitly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions