Bump rdk#92
Merged
Sean Pollock (seanavery) merged 3 commits intoMay 27, 2026
Merged
Conversation
Sean Pollock (seanavery)
force-pushed
the
tagger-fix
branch
from
e254891 to
cde1d24
Compare
| func (c *component) Image(_ context.Context, _ string, _ map[string]interface{}) ([]byte, camera.ImageMetadata, error) { | ||
| return nil, camera.ImageMetadata{}, errors.New("camera.Image not implemented") | ||
| func (c *component) Status(_ context.Context) (map[string]interface{}, error) { | ||
| return map[string]interface{}{}, nil |
Collaborator
Author
There was a problem hiding this comment.
should we implement Status?
There was a problem hiding this comment.
maybe could return the storage state?
Collaborator
Author
There was a problem hiding this comment.
Could be a good idea -- i can create a follow-up
Sean Pollock (seanavery)
requested review from
a team,
Josh Matthews (jmatth) and
oliviamiller
and removed request for
a team
oliviamiller
approved these changes
May 27, 2026
Josh Matthews (jmatth)
approved these changes
May 27, 2026
Sean Pollock (seanavery)
merged commit ee0ce2e
into
viam-modules:main
5 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RDK dep was super old. Simple bump and test adjustments.
Testing