Skip to content

Stop SDK-coverage check crashing on inherited methods (#5126) #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btshrewsbury-viam merged 2 commits into from
Jul 2, 2026
Merged

Stop SDK-coverage check crashing on inherited methods (#5126) #5139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f2d116
Stop coverage check crashing on proto methods missing from an SDK scr…
btshrewsbury-viam Jul 2, 2026
f4dc0b5
Merge branch 'main' into fix/coverage-partial-sdk-methods
shannonbradshaw Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/update_sdk_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,23 @@ def write_markdown(type, names, methods):
flutter_method_name = row.split(',')[5].rstrip()
typescript_method_name = row.split(',')[6].rstrip()

## A proto RPC can map to an SDK method that the SDK's own
## resource doc page does not surface -- for example gripper's
## CurrentInputs/GoToInputs, which are inherited via
## framesystem.InputEnabled and documented on that interface's
## page, not the gripper page. If the scraper did not find the
## mapped method for a given SDK, treat that SDK as not having
## it so the proto still documents in the SDKs that do surface
## it, instead of raising a KeyError.
if py_method_name and "python" in sdks and py_method_name not in methods['python'][type].get(resource, {}):
py_method_name = ''
if go_method_name and "go" in sdks and go_method_name not in methods['go'][type].get(resource, {}):
go_method_name = ''
if flutter_method_name and "flutter" in sdks and flutter_method_name not in methods['flutter'][type].get(resource, {}):
flutter_method_name = ''
if typescript_method_name and "typescript" in sdks and typescript_method_name not in methods['typescript'][type].get(resource, {}):
typescript_method_name = ''

if py_method_name and "python" in sdks:
methods['python'][type][resource][py_method_name]["used"] = True
if go_method_name and "go" in sdks:
Expand Down
Loading