RSDK-654 - refactor message handling for streaming#184
Open
Ethan (stuqdog) wants to merge 2 commits into
Open
Conversation
Ethan (stuqdog)
requested review from
Allison Chiang (allisonschiang) and
martha-johnston
Member
|
Ethan (@stuqdog) - I haven't dug into the code, but I have pulled this PR locally and confirmed that in my repro environment, I no longer see the arm wait until all the points have been sent on the stream. So this looks promising! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors message handling to send messages asynchronously as soon as they come in, defer sending EOS until client messages are demonstrably completed, and only as its own frame.