optional move to directory#20
Open
dorien-er wants to merge 5 commits into
Open
Conversation
jakubmajercik
requested changes
Mar 12, 2026
Comment on lines
+40
to
+43
| if [[ ${#file_ids[@]} -ne ${#input_paths[@]} ]]; then | ||
| echo "Error: Number of file IDs (${#file_ids[@]}) must match number of input paths (${#input_paths[@]})" | ||
| exit 1 | ||
| fi |
Contributor
There was a problem hiding this comment.
- Could you add a more descriptive error if
--output_summaryis passed but--file_idis not? - Add a check if the
input_pathfile exists and then skip this file - remove thefile_id
Contributor
Author
There was a problem hiding this comment.
- extra check is added
- This is already handled here:
craftbox/src/move_files_to_directory/script.sh
Lines 70 to 72 in 304df5c
jakubmajercik
approved these changes
Mar 16, 2026
jakubmajercik
left a comment
jakubmajercik
left a comment
Contributor
There was a problem hiding this comment.
LGTM but I think @DriesSchaumont still wanted to take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.