Skip to content

Fix Vibe.d nightly (phobos/5355: ISharedAllocator)#1774

Merged
s-ludwig merged 2 commits intovibe-d:masterfrom
wilzbach:make-vibed-working-with-nightly
Jun 28, 2017
Merged

Fix Vibe.d nightly (phobos/5355: ISharedAllocator)#1774
s-ludwig merged 2 commits intovibe-d:masterfrom
wilzbach:make-vibed-working-with-nightly

Conversation

@wilzbach
Copy link
Copy Markdown
Member

@wilzbach wilzbach commented May 29, 2017

Since 2.074.0 I could observe at least three regressions:

This is a dirty workaround against the ISharedAllocator changes and allows vibe.d to be built again.

@PetarKirov
Copy link
Copy Markdown
Contributor

Thanks for doing this! If it's not too much work, can you separate the two workarounds in separate commits and a a link to the respective PRs that introduced the breakage?

@wilzbach wilzbach force-pushed the make-vibed-working-with-nightly branch 3 times, most recently from 76e7570 to 68a98b1 Compare June 3, 2017 18:31
@wilzbach
Copy link
Copy Markdown
Member Author

wilzbach commented Jun 3, 2017

Thanks for doing this! If it's not too much work, can you separate the two workarounds in separate commits and a a link to the respective PRs that introduced the breakage?

Not at all.
I also reworded the the intro of this PR to reflect the current situation.

@SerialVelocity
Copy link
Copy Markdown

@wilzbach @ZombineDev There seems to be another issue now:

../../../.dub/packages/vibe-d-0.8.0-beta.7/vibe-d/core/vibe/core/sync.d(143,2): Error: @safe constructor 'vibe.core.sync.LocalTaskSemaphore.this' cannot call @system destructor 'vibe.core.sync.LocalTaskSemaphore.~this
../../../.dub/packages/vibe-d-0.8.0-beta.7/vibe-d/http/vibe/http/server.d(832,2): Error: @safe constructor 'vibe.http.server.HTTPServerRequest.this' cannot call @system destructor 'vibe.http.server.HTTPServerRequest.~this'

@wilzbach
Copy link
Copy Markdown
Member Author

@wilzbach @ZombineDev There seems to be another issue now:

Yeah - isn't that fun? ;-)
Also in Vibe.d 0.7.31-rc.2 there is/was also an ICE - luckily it's just a regression from dlang/phobos#5427 now.

@MartinNowak
Copy link
Copy Markdown
Contributor

The Allocator part would be needed for 2.075.0 to work.

@wilzbach wilzbach force-pushed the make-vibed-working-with-nightly branch from 68a98b1 to 52782dc Compare June 28, 2017 12:39
@wilzbach
Copy link
Copy Markdown
Member Author

I just realized that disposeMultidimensionalArray and makeMultidimensionalArray has been added in 2.074 (dlang/phobos#4982), so it's better to avoid importing them (this lead to the CI build failures).

@s-ludwig
Copy link
Copy Markdown
Member

@wilzbach Thanks a lot! I'll merge and then rename the vibe.d version of processAllocator to avoid name clashes/confusion.

@s-ludwig s-ludwig merged commit e8bea30 into vibe-d:master Jun 28, 2017
@wilzbach wilzbach deleted the make-vibed-working-with-nightly branch June 28, 2017 15:08
@MartinNowak
Copy link
Copy Markdown
Contributor

Using the thread-safe theAllocator might be an option as well.

@s-ludwig
Copy link
Copy Markdown
Member

@MartinNowak: Unfortunately fails (it was actually originally used, but I had to switch to processAllocator because of this): dlang/phobos#5519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants