fix(ci): fork Verify issue reporting을 upstream 호환으로 조정#25
Open
seonghobae wants to merge 1 commit into
Open
Conversation
|
@seonghobae is attempting to deploy a commit to the Sumin Choi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
검토 메모 (2026-06-14 KST)
검증:
남은 외부/환경 이슈:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
Verifyworkflow가 fork repository에서 실행될 때, 실패 알림용 GitHub issue를 현재 실행 repository에 생성하려고 합니다. fork에서 Issues가 꺼져 있으면Open or update verify issue단계가Issues has been disabled in this repository로 실패하고, 실제 coverage/gate 실패를 보고하기 전에 workflow가 잘못된 이유로 종료됩니다.실패 예시: https://github.com/Seongho-Bae/vooster/actions/runs/27404184648/job/80989079016
변경 사항
VSPEC_VERIFY_ISSUE_REPOSITORY가 설정되어 있으면 명시 target을 우선합니다.GITHUB_TOKEN으로 upstream issue write가 불가능한 GitHub 권한 모델을 반영했습니다.VSPEC_VERIFY_ISSUE_TOKEN이 없으면 issue update/close를 시도하지 않고 warning 후 skip합니다.Fail workflow if any check failed단계가 담당합니다.운영 영향
VSPEC_VERIFY_ISSUE_TOKENsecret을 제공하면 됩니다.검증
통과:
pnpm vitest run apps/cli/tests/unit/verify-action.test.ts apps/cli/tests/unit/verify-issue-target.test.tspnpm typecheckpnpm exec prettier --check .github/workflows/verify.yml apps/cli/tests/unit/verify-action.test.ts apps/cli/tests/unit/verify-issue-target.test.ts scripts/verify-issue-target.js scripts/verify-issue-target.d.tspnpm lintpnpm -r build추가 확인:
bash scripts/completion-check.sh는 1차 실행에서 build artifact가 없어@vooster/contracts/dist/index.js를 못 찾아 실패했습니다.pnpm -r build후 재실행하자 contracts dist 문제는 해결됐습니다.127.0.0.1:5433에 떠 있지 않아 honest E2E 계열이 실패했습니다.goals/30-in-tree-isolation도 기존 gate script의 shared build invocation을 지적했습니다. 이번 PR의 변경 파일과 직접 관련된 실패는 아닙니다.