fix(app): add aria-controls to table group toggles#27
Open
seonghobae wants to merge 4 commits into
Open
Conversation
**What:** Added `aria-controls` attributes to the group toggle buttons in the `ActorTable` and `UsecaseTable` components, matching the toggled content's `id`. Added a `.Jules/palette.md` journal entry with this learning. **Why:** Screen reader users will now be able to explicitly understand which element is being expanded or collapsed when interacting with the group headers. **Accessibility:** Improved screen reader context for collapsible table groups.
**What:** Added aria-controls attributes to the group toggle buttons in the ActorTable and UsecaseTable components, matching the toggled content's id. Added a .Jules/palette.md journal entry with this learning. Also fixed failing CI tests. **Why:** Screen reader users will now be able to explicitly understand which element is being expanded or collapsed when interacting with the group headers. **Accessibility:** Improved screen reader context for collapsible table groups.
**What:** Added aria-controls attributes to the group toggle buttons in the ActorTable and UsecaseTable components, matching the toggled content's id. Added a .Jules/palette.md journal entry with this learning. Also fixed failing CI tests. **Why:** Screen reader users will now be able to explicitly understand which element is being expanded or collapsed when interacting with the group headers. **Accessibility:** Improved screen reader context for collapsible table groups.
**What:** Added aria-controls attributes to the group toggle buttons in the ActorTable and UsecaseTable components, matching the toggled content's id. Added a .Jules/palette.md journal entry with this learning. Also fixed failing CI tests. **Why:** Screen reader users will now be able to explicitly understand which element is being expanded or collapsed when interacting with the group headers. **Accessibility:** Improved screen reader context for collapsible table groups.
|
@seonghobae is attempting to deploy a commit to the Sumin Choi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forwarded from fork PR 21: ContextualWisdomLab#21
Adds aria-controls/id wiring for ActorTable and UsecaseTable collapsible group toggles. Fork CI had lint/typecheck and tests green; non-blocking Verify was failing.
Review Notes
Validation