Skip to content

fix: remove unsupported HTML upload option from admin document picker #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandeep-2536 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove unsupported HTML upload option from admin document picker #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions apps/frontend/src/admin/pages/AdminContextSources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,9 +631,6 @@ export function WebUrlView({ bare = false }: { bare?: boolean } = {}) {
/**
* UploadDocumentView — file-upload form + list for `DocumentAsset`.
* Self-contained: owns its own state, fetches `/admin/documents`.
* v1.83 — `.html` / `.htm` added to the accept= list; uploads will
* still be rejected by the backend until ALLOWED_MIME in
* adminDocuments.controller.ts is extended (tracked as a TODO).
*/
export function UploadDocumentView({ bare = false }: { bare?: boolean } = {}) {
const [items, setItems] = useState<DocumentRow[]>([]);
Expand Down Expand Up @@ -704,7 +701,7 @@ export function UploadDocumentView({ bare = false }: { bare?: boolean } = {}) {
} catch (e) {
const status = (e as { response?: { status?: number } })?.response?.status;
let msg = friendlyError(e, 'Upload failed.');
if (status === 400) msg = 'That file type is not supported. Use PDF, TXT, MD, CSV, HTML, or HTM.';
if (status === 400) msg = 'That file type is not supported. Use PDF, TXT, MD, or CSV.';
else if (status === 422) msg = 'We could not extract any text from that file.';
setUploadError(msg);
} finally {
Expand Down Expand Up @@ -810,12 +807,7 @@ export function UploadDocumentView({ bare = false }: { bare?: boolean } = {}) {
<input
id="context-doc-file"
type="file"
// v1.83 — accept HTML too. Backend ALLOWED_MIME set does NOT
// yet include `text/html` / `application/xhtml+xml`; a
// follow-up backend PR will add extraction support. Until
// then an HTML upload returns 400 and the existing error
// path displays "unsupported file type".
accept=".pdf,.txt,.md,.csv,.html,.htm"
accept=".pdf,.txt,.md,.csv"
onChange={handleFileChange}
disabled={uploadPending}
aria-label="Document file"
Expand Down Expand Up @@ -924,7 +916,7 @@ export function UploadDocumentView({ bare = false }: { bare?: boolean } = {}) {
return (
<AdminCard
title="Documents"
subtitle="Upload a PDF, TXT, MD, CSV, HTML, or HTM. Text is extracted and indexed for retrieval."
subtitle="Upload a PDF, TXT, MD, or CSV. Text is extracted and indexed for retrieval."
>
{body}
</AdminCard>
Expand Down
1 change: 1 addition & 0 deletions apps/frontend/src/admin/pages/__tests__/AdminContextSources.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ describe('AdminContextSources', () => {

const file = new File(['hello world'], 'uploaded.pdf', { type: 'application/pdf' });
const fileInput = screen.getByTestId('documents-file-input') as HTMLInputElement;
expect(fileInput.accept).toBe('.pdf,.txt,.md,.csv');
fireEvent.change(fileInput, { target: { files: [file] } });

// Selected-file hint surfaces.
Expand Down