Skip to content

fix(bitwarden): reopen vault after unlocking - #407

Open
vieitesss wants to merge 1 commit into
vicinaehq:mainfrom
vieitesss:fix/bitwarden-unlock-reopen
Open

vieitesss wants to merge 1 commit into
vicinaehq:mainfrom
vieitesss:fix/bitwarden-unlock-reopen

Conversation

@vieitesss

@vieitesss vieitesss commented Sep 24, 2026 •

Copy link
Copy Markdown

Why the change

Keep Bitwarden’s vault command available while rbw unlock runs so GUI pinentry can receive focus, then reopen the same command with the unlocked entries.

Special things to note

  • Unlock still requires manual confirmation in the GUI pinentry; the command now allows up to 120 seconds for it.
  • The reopen flow tolerates an “Already closed” CLI response and uses command-specific vicinae-cli cmd launch rather than a toggle.

Change outline

Unlock remains in the foreground for pinentry, then refreshes the list and explicitly closes/reopens the command:

 on Unlock Vault
-  closeMainWindow()
-  runRbw(["unlock"])
+  runRbw(["unlock"], timeout: 120s)  // keep the GUI available for pinentry
   set unlocked
-  load entries
+  if load entries succeeds
+    close suspended root (treat “Already closed” as success)
+    launch this extension command
+  if reopen fails
+    restore Vicinae window and show failure

@clankus-aurelius

clankus-aurelius commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks for contributing an extension to Vicinae! 👋

Before publication, this pull request receives two reviews:

  1. An automated review for extension guidelines, safety, error handling, and likely correctness issues.
  2. A final review from a Vicinae maintainer.

⚠️ Automated review failed. A maintainer can retry by commenting @clankus-aurelius review.

Codex stream failed: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Sep 26th, 2026 3:50 PM.

The automated reviewer examines only the current commit. New commits invalidate its previous decision and start another review.

@clankus-aurelius clankus-aurelius added ai-reviewing Automated extension review is running ai-review-failed Automated review could not complete and removed ai-reviewing Automated extension review is running labels Sep 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-failed Automated review could not complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants