Cleanup, gcc warnings, msvc compatibility #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… m) from bool to void
…tSequence::load_list()
…) case when arraysize is less than 2 Fixes gcc warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false.
…un-initialized variable
Ah yes, the fast math. The historic relic of little value on the modern platforms, and source of undefined C++ behavior due to breaking strict aliasing rules with type-punting.
…ndOpenCV.cmake works just fine Also, -std=c++0x should be defined on Windows only if we are using gcc...
A typo in cmake/LegitUtilities.cmake made configuration registration effectively a no-op. And LGT configuration file was in wrong place...
Because .dll goes to runtime, and .lib goes to library destination.
…s pass on MSVC2013
Pretty much the same as the unix version...
…sses' methods MSVC seems to be taking offense with them, and they're pointless anyway...
…rect path to getopt_win.h header
…C2013 Annotated just the parts of the library that appear to be used by legit_runner, though (i.e., the ones that triggered build errors); for a complete/proper annotation, the actual library's interface should be established...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first half of the PR fixes several classes of gcc warnings, and the second half enables support for The Other Compiler.