fix(constellarium): round 3.1 — pan restored, phantom pin removed, WebGL guard - #150
Merged
Merged
Conversation
vicquick
enabled auto-merge (squash)
August 22, 2026 06:52
…bGL guard
Empirically verified against a raw-CDP Playwright-free harness (playwright-
python leaked ~3MB/s of retained exceptionThrown events and got cgroup-OOM-
killed at 4GB attaching to this page): all nine behaviour asserts green —
hover engage/release, node drag, background pan moves the world, pan not
hijacked after drag, click pins, pin dismisses, zoom cursor-anchored.
Three real defects found by the harness:
- grab radius (nodeRadius+4, floor 10 world units) was wider than the pixi
hitArea (nodeRadius+2): an empty-sky press silently grabbed an unseen
star, so d3-drag claimed the gesture and background pan never reached
d3-zoom. Grab now mirrors the hitArea exactly.
- pixi pointertap pinned after EVERY node drag: the dragged star travels
with the cursor, so pixi sees down+up over the same object. Click-to-pin
now lives solely in d3-drag's end handler (pointer distance < 5px).
- pixi's canvas fallback has no pipe for the round-3 GL link mesh and threw
on every render — a 60fps uncaught-exception storm with frozen world and
stale hit tests. Non-WebGL renderers now get a quiet notice instead.
Deps: pixi.js 8.20, d3-{force,selection,zoom,drag,transition}, tween.js
(round-3 render core: single GPU mesh for links, shared hover animation).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0137xgmfhc8co2pjNDuZw6FR
vicquick
force-pushed
the
fix/constellarium-obsidian-round3
branch
from
August 22, 2026 06:53
b68e42d to
81a590e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the "still doesn't behave like Obsidian" thread with empirical verification: a raw-CDP behaviour suite (no playwright — playwright-python retained every
exceptionThrownCDP event from a 60fps render-error storm, leaked ~3MB/s and was cgroup-OOM-killed at 4GB) runs nine asserts against the live view, all green:Three real defects the harness surfaced:
grabSubjectusednodeRadius+4with a 10-world-unit floor while the pixi hitArea isnodeRadius+2. An empty-sky press silently grabbed an unseen star; d3-drag claimed the gesture and the pan never reached d3-zoom. Grab now mirrors the hitArea: if it isn't hoverable, it isn't grabbable.pointertapfires when down+up land on the same object, and a dragged star travels with the cursor, so every drag ended pinned. Click-to-pin now lives solely in d3-drag's end handler (pointer distance < 5 px).Round-3 render core (single GPU mesh for all links — no per-frame tessellation of 58k strokes; one shared hover animation instead of 60k tween allocations) rides along with its deps: pixi.js 8.20, d3 modules, tween.js.
Dev-only test seam:
window.__appexposed underimport.meta.env.DEVfor the behaviour suite.🤖 Generated with Claude Code
https://claude.ai/code/session_0137xgmfhc8co2pjNDuZw6FR