Skip to content

Add EdgeV2 engine - #8

Merged
vieirin merged 11 commits into
mainfrom
edge-v2
Jul 19, 2026
Merged

Add EdgeV2 engine#8
vieirin merged 11 commits into
mainfrom
edge-v2

Conversation

@vieirin

@vieirin vieirin commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Introduce the EdgeV2 engine (packages/lib/src/engines/edgeV2/) with MDP templates, goal pursue logic (AND/OR), validators, logging, and mapping
  • Extend grammar/types and examples for the new goal forms (including any-order AND), plus expected-output coverage
  • Wire EdgeV2 into the UI (engine selector, transform API, report/output viewers)

Test plan

  • Run EdgeV2 transform on examples/EDGEV2.txt and confirm output matches expectations
  • Exercise AND / OR / any-order AND pursue paths in the UI
  • Confirm legacy Edge engine still works unchanged via the engine selector
  • Run unit tests under packages/lib (especially andGoal.test.ts)

Made with Cursor

@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
goal-controller Ready Ready Preview, Comment Jul 19, 2026 11:37pm

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@vieirin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e64aaaa-7d3e-4131-bfae-a9cb4926676a

📥 Commits

Reviewing files that changed from the base of the PR and between 4146c6b and 5c20889.

⛔ Files ignored due to path filters (1)
  • .DS_Store is excluded by !**/.DS_Store
📒 Files selected for processing (84)
  • .cursor/rules/edgev2-leave-edge-untouched.mdc
  • .ollie/audit.jsonl
  • dissertationExamples/dualGoalOrAny.txt
  • dissertationExamples/goalModel TAS 1.txt
  • dissertationExamples/goalModel TAS 2.txt
  • dissertationExamples/goalModel(16).txt
  • dissertationExamples/goalModelTAS_new.txt
  • examples/EDGEV2.txt
  • examples/experiments/10-minimalMaintainResource.txt
  • examples/experiments/4-interleavedChoicePDegradation.txt
  • examples/experiments/5-allAnnotations.txt
  • examples/experiments/6-allnotationsReduced.txt
  • examples/experiments/7-minimalAll.txt
  • examples/experiments/8-minimalMaintain.txt
  • examples/experiments/9-minimalMaintainContext copy.txt
  • examples/experiments/9-minimalMaintainContext.txt
  • examples/experiments/goalModel_TAS_3.txt
  • examples/experiments/labSamplesWithSideEffect.txt
  • examples/experiments/props/10-minimalMaintainResource.props
  • examples/experiments/props/4-interleavedChoicePDegradation.props
  • examples/experiments/props/6-allnotationsReduced.props
  • examples/experiments/props/7-minimalAll.props
  • examples/experiments/props/8-minimalMaintain.props
  • examples/experiments/props/9-minimalMaintainContext.props
  • examples/experiments/props/goalModel_TAS_3.props
  • examples/goalModel_TAS_3_.expected.txt
  • examples/goalModel_TAS_3_.txt
  • examples/labSamplesWithSideEffect_.txt
  • examples/props/goalModel_TAS_3.props
  • examples/simpleChoice.txt
  • packages/goal-tree/src/antlr/RTRegexLexer.ts
  • packages/goal-tree/src/antlr/RTRegexListener.ts
  • packages/goal-tree/src/antlr/RTRegexParser.ts
  • packages/goal-tree/src/parsers/goalNameParser.ts
  • packages/goal-tree/src/types/goalTree.ts
  • packages/goal-tree/test/parsers/goalNameParser.test.ts
  • packages/lib/grammar/RTRegex.g4
  • packages/lib/src/antlr/AssertionRegexLexer.ts
  • packages/lib/src/antlr/AssertionRegexListener.ts
  • packages/lib/src/antlr/AssertionRegexParser.ts
  • packages/lib/src/antlr/RTRegexLexer.ts
  • packages/lib/src/antlr/RTRegexListener.ts
  • packages/lib/src/antlr/RTRegexParser.ts
  • packages/lib/src/engines/edge/types.ts
  • packages/lib/src/engines/edgeV2/index.ts
  • packages/lib/src/engines/edgeV2/logger/logger.ts
  • packages/lib/src/engines/edgeV2/mapper.ts
  • packages/lib/src/engines/edgeV2/mdp/common.ts
  • packages/lib/src/engines/edgeV2/retryCoercion.ts
  • packages/lib/src/engines/edgeV2/template/common.ts
  • packages/lib/src/engines/edgeV2/template/decisionVariables.ts
  • packages/lib/src/engines/edgeV2/template/index.ts
  • packages/lib/src/engines/edgeV2/template/modules/changeManager/template/achievabilityVariables/taskAchievabilityVariables.ts
  • packages/lib/src/engines/edgeV2/template/modules/changeManager/template/tasks/transitions.ts
  • packages/lib/src/engines/edgeV2/template/modules/changeManager/template/tasks/variables.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/achieve.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/formulas.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/index.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/pursue/andGoal.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/pursue/common.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/pursue/decisionGuards.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/pursue/index.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/pursue/orGoal.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/skip.ts
  • packages/lib/src/engines/edgeV2/template/modules/goalModule/template/variables.ts
  • packages/lib/src/engines/edgeV2/template/prismGuards.ts
  • packages/lib/src/engines/edgeV2/types.ts
  • packages/lib/src/engines/edgeV2/validator/expectedElements.ts
  • packages/lib/src/engines/edgeV2/validator/index.ts
  • packages/lib/src/engines/edgeV2/validator/parser.ts
  • packages/lib/src/engines/edgeV2/validator/report.ts
  • packages/lib/src/engines/edgeV2/validator/types.ts
  • packages/lib/src/engines/edgeV2/validator/validator.ts
  • packages/lib/src/engines/index.ts
  • packages/lib/src/index.ts
  • packages/lib/test/engines/edgeV2/template/modules/goalModule/template/pursue/andGoal.test.ts
  • packages/ui/app/api/transform/route.ts
  • packages/ui/app/layout.tsx
  • packages/ui/components/EngineSelector.tsx
  • packages/ui/components/OutputViewer.tsx
  • packages/ui/components/ReportViewer.tsx
  • packages/ui/components/TransformWorkflow.tsx
  • packages/ui/lib/models/goal.ts
  • packages/ui/lib/types.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch edge-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
Remove unused main-only helpers that depended on discarded APIs, and
dedupe EdgeV2 exports / parseForEdgeV2 after the merge.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vieirin
vieirin merged commit 601af76 into main Jul 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant