refactor: cwd to go - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a small Go-based JSON-RPC server (built as bin/nvim-features) and a corresponding Neovim Lua client module (features/test-rpc) that connects over a per-process socket. It also includes a couple of config tweaks (miniharp notifications and an extra cwd path) and ignores the built binary output directory.
Changes:
- Add a Go module with a simple JSON-RPC server exposing a
Multiplymethod, plus build instructions. - Add a Lua
features/test-rpcclient that starts the Go binary, connects via socket, and sends JSON-RPC requests. - Minor config updates: disable miniharp notifications, add a cwd path, and ignore
bin/.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/plugins.lua | Disables miniharp notifications via config. |
| lua/features/test-rpc/init.lua | Adds Lua client to start/connect to a socket-based JSON-RPC server and send Multiply requests. |
| init.lua | Adds an extra path to the cwd feature configuration. |
| go/README.md | Documents the new Go “features” area and test-rpc. |
| go/main.go | Implements the Go JSON-RPC server and Unix-socket listener. |
| go/justfile | Adds a build recipe to produce bin/nvim-features. |
| go/go.mod | Introduces the Go module definition and dependencies. |
| go/go.sum | Adds dependency checksums. |
| go/features/cwd/main.go | Implements the Multiply RPC handler (currently under cwd package). |
| .gitignore | Ignores the generated bin/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- fix(cwd/go): correct normalize ~ expansion, preserve path in error msgs - fix(cwd/lua): mark CwdConfig fields optional, fix warning msg format - fix(keymaps): remove duplicate <leader>l mapping - fix(lockfile): remove unused fzf-lua and rose-pine pins
When a configured path cannot be normalized or read, log a warning and continue to the next path instead of returning a hard error. This matches the old Lua behavior where missing directories were gracefully skipped.
When the files pipeline exits with a non-zero, non-cancel code, notify the user instead of silently doing nothing. Matches the error handling pattern already used in find_elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.