[OPTIMISATION] fetch platform specific chrome image#12
Open
realityzero wants to merge 1 commit intovikiival:mainfrom
Open
[OPTIMISATION] fetch platform specific chrome image#12realityzero wants to merge 1 commit intovikiival:mainfrom
realityzero wants to merge 1 commit intovikiival:mainfrom
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @vikiival on Vercel. @vikiival first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
Hey thanks for the PR! I am currently away from Github, will get back to this PR next week |
Author
|
Hey @vikiival ! Were you able to take a look at this? |
vikiival
reviewed
Mar 22, 2024
Owner
vikiival
left a comment
vikiival
left a comment
There was a problem hiding this comment.
Looks okish, just small things
| args: [...chrome.args, '--hide-scrollbars', '--disable-web-security'], | ||
| defaultViewport: chrome.defaultViewport, | ||
| executablePath: await chrome.executablePath( | ||
| `https://github.com/Sparticuz/chromium/releases/download/v116.0.0/chromium-v116.0.0-pack.tar` |
Author
There was a problem hiding this comment.
There are 3 ways to do this:
- Keep a chromium tar file in code and supply that as an executable. Caveat: increases bundle size.
- Store the chromium tar in personal S3 bucket or something similar.
- Use github tar file
Either ways we need to provide an executable in Cloud Environment.
Owner
There was a problem hiding this comment.
This was an original code that worked on Vercel
executablePath: await chrome.executablePath(),
Comment on lines
+42
to
+46
| process.platform === "win32" | ||
| ? "C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe" | ||
| : process.platform === "linux" | ||
| ? "/usr/bin/google-chrome" | ||
| : "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code works w/ different environments now