fix: resolve test failures in PR #13#18
Closed
vikram-blaxel wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix for failing tests in #13.
Changes made:
The issue was that the
bookstable schema required a non-nullpublishercolumn, but the application code (inrepositories.pyandmodels.py) did not handle this field, resulting in integrity violations during tests. I modifiedmodels.pyto make thepublisherfield optional in the SQLAlchemy model and provided a default value in theBookInPydantic model to ensure compatibility with existing code. Additionally, I updatedrepositories.pyto correctly include thepublisherfield when creating or updating records in the database.