decoding_jpeg_image#2
Conversation
| /*unsigned char *buf[3];*/ | ||
| unsigned int num_scanlines; | ||
| /* Process data */ | ||
| while(cinfo.output_scanline < cinfo.output_height) { |
There was a problem hiding this comment.
Okay. This seems problematic! Do we have output height at this point?
| @@ -0,0 +1,72 @@ | |||
| #include <stdio.h> | |||
There was a problem hiding this comment.
The example is for jpeg_decoder and the folder is esp32_jpeg_enc?
There was a problem hiding this comment.
@Suyash20012000 did you test the code?
Add a proper description in README
I did not test the code. I was not sure about the 'process' part of the code. Also what are your views on the flow of the code. I mean the flow in which the API's are called and the changes I did to the orignal program. Was it on the right track?
| ); | ||
|
|
||
| unsigned long in_buf_sz = 96 * 96 * 4; | ||
| unsigned char in_buf[96 * 96 * 4]; |
| unsigned char *out_buf | ||
| ); | ||
|
|
||
| unsigned long in_buf_sz = 96 * 96 * 4; |
There was a problem hiding this comment.
Number 96x96 doesn't make sense.
Use something to denote how much KB. e.g 10 * 1024 meaning 10KB
| @@ -0,0 +1,1272 @@ | |||
| # | |||
| # Automatically generated file. DO NOT EDIT. | |||
There was a problem hiding this comment.
sdkconfig and sdkconfig.old are generated files. Do not add them to commit.
| vTaskDelete(NULL); | ||
| } | ||
|
|
||
| void app main() |
There was a problem hiding this comment.
Error. Change this to app_main.
| send_email(out_buf); | ||
| vTaskDelete(NULL); | ||
| } | ||
|
|
There was a problem hiding this comment.
Instead of adding files to existing esp32_jpeg_enc which is for encoder, create new example: esp32_jpeg_dec.
|
@Suyash20012000 did you test the code? Add proper description in README |
|
@Suyash20012000 please add proper description to PR. For example: espressif/esp-idf@77afbd5 |
|
Ok sir. I'll look in the folder name and other changes mentioned. |
2 participants
No description provided.