Skip to content

Whitespace: remove trailing spaces, ensure end-of-file newline - #188

Open
mernst wants to merge 2 commits into
mainfrom
whitespace
Open

Whitespace: remove trailing spaces, ensure end-of-file newline#188
mernst wants to merge 2 commits into
mainfrom
whitespace

Conversation

@mernst

@mernst mernst commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@mernst, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 018c21dd-05ab-4fde-a3ed-f7743d7537f0

📥 Commits

Reviewing files that changed from the base of the PR and between 85b0f72 and ff505c5.

📒 Files selected for processing (2)
  • .github/workflows/style.yml
  • Makefile
📝 Walkthrough

Walkthrough

The pull request normalizes whitespace, indentation, closing-brace placement, and Markdown formatting across source files, documentation, and test fixtures. It adds ignored whitespace handling to the CBMC grammar, updates specification-generation prompts, adds syntax-fixer coverage for multiple ellipses, cleans generated proofstate files after integration tests, and adjusts related expected outputs. It also adds .env to the models ignore list and updates verification support artifacts.

Possibly related PRs

Suggested reviewers: jyoo980

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 26.19% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch whitespace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@data/p02369.c`:
- Around line 89-91: Check the result of malloc before dereferencing n in the
edge-list node creation flow. If allocation fails, propagate the failure or
terminate through the existing intended error path; only assign n->e and n->nxt
after confirming n is non-NULL.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8e38e612-1619-407d-a67a-c9af1435c593

📥 Commits

Reviewing files that changed from the base of the PR and between 8b4c7f7 and 85b0f72.

📒 Files selected for processing (53)
  • Dockerfile
  • data/cbmc_regression/assigns_enforce_arrays_05/test.desc
  • data/cbmc_regression/assigns_enforce_structs_08/test.desc
  • data/factorial_iterative.c
  • data/factorial_recursive.c
  • data/max_min.c
  • data/p00071.c
  • data/p00244.c
  • data/p00855.c
  • data/p02369.c
  • data/qsort.c
  • data/qsort_with_docs.c
  • data/rust_qsort/src/main.rs
  • docs/cbmc/contracts-function-pointer-predicates.md
  • docs/cbmc/contracts-history-variables.md
  • docs/cbmc/contracts-memory-predicates.md
  • docs/cbmc/contracts-quantifiers.md
  • models/.gitignore
  • prompts/generate-specifications-prompt-template.txt
  • prompts/repair-specifications-prompt-template.txt
  • test/data/avocado_stub/test_header_detection.c
  • test/data/avocado_stub/test_renaming_existing_avocado_names.c
  • test/data/avocado_stub/test_renaming_no_existing_avocado_names.c
  • test/data/avocado_stub/test_renaming_with_cbmc_specs.c
  • test/data/callgraph/ordering.c
  • test/data/callgraph/ordering_copy.c
  • test/data/callgraph/self_recursion.c
  • test/data/function_util/multiple_multi_line_spec.c
  • test/data/function_util/multiple_single_line_specs.c
  • test/data/function_util/no_specs.c
  • test/data/function_util/quantifiers.c
  • test/data/function_util/single_multi_line_spec.c
  • test/data/function_util/update_function_definition/swap_bottom.c
  • test/data/function_util/update_function_definition/swap_bottom_with_specs.c
  • test/data/function_util/update_function_definition/swap_middle.c
  • test/data/function_util/update_function_definition/swap_middle_with_specs.c
  • test/data/function_util/update_function_definition/swap_top.c
  • test/data/function_util/update_function_definition/swap_top_with_specs.c
  • test/data/get_comments/test.c
  • test/data/get_source_code/test.c
  • test/data/get_source_code/test_with_doc_comments.c
  • test/integration/test_generate_specs.py
  • test/translation/test_cbmc_specification_mutant_generator.py
  • test/util/test_c_function.py
  • test/util/test_code_extraction_util.py
  • test/util/test_function_util.py
  • test/util/test_spec_syntax_fixer.py
  • test/verification/test_verification_input.py
  • translation/grammar/cbmc.txt
  • verification-algorithm.md
  • verification/cbmc_stubs/c_keywords.txt
  • verification/cbmc_stubs/math.c
  • verification/docs/ansi_c_library_documentation.json
💤 Files with no reviewable changes (3)
  • data/factorial_iterative.c
  • test/integration/test_generate_specs.py
  • test/util/test_spec_syntax_fixer.py

Comment thread data/p02369.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant