Repository navigation
Harden peer metadata validation - #45
Open
vikranthreddimasu wants to merge 4 commits into
Open
vikranthreddimasu wants to merge 4 commits into
vikranthreddimasu wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of improvements
HardwareExchange.Security changes
Usability changes
Tests/checks run
python -m pytest tests/test_security/test_hw_exchange.py -q(red first: 17 failures, then 41 passed)python -m pytest tests/test_pool/test_topology.py -q(red first for new cases, then 16 passed)python -m pytest tests/test_security/test_fleet_discovery.py -q(red first: 7 failures, then 24 passed)python -m pytest tests/test_security/test_hw_exchange.py tests/test_fuzz/test_fuzz_hw_exchange.py -q(51 passed)python -m pytest tests/test_pool/test_topology.py tests/test_pool/test_network.py tests/test_pool/test_registry.py -q(37 passed)python -m pytest tests/test_security/test_fleet_discovery.py tests/test_pool/test_peer_removed.py tests/test_pool/test_registry.py -q(37 passed)make lint(ruff passed; mypy passed with existing quantize.py note)python -m pytest tests/ -q(1021 passed, 2 expected deprecation warnings)git diff --check master...HEADrgCommit list
Risks or manual review notes
data_port/portrecords now reject instead of being cached.Whether the PR was merged