Repository navigation
Improve task timeout and wire validation - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskDispatcher.map()results concurrently so per-task wait timeout does not multiply by input size.TaskFuture.result()timeout values before creating wait coroutines.errorpayloads and task kwargs with invalid wire keys.Security changes
Usability changes
ValueErrorinstead of leaking lower-level asyncio behavior.Tests/checks run
python -m pytest tests/test_compute/test_dispatch.py tests/test_compute/test_models.py -qpython -m pytest tests/test_compute/ -qmake lintmake test(1015 passed, 2 warnings)git diff --check master...HEADrgCommits
3971f23Fix task map timeout semantics69e2d3dValidate task result error payloadsc29fc7bValidate task kwargs on the wireRisks / manual review notes
Merge status
masterafter local checks, diff-only secret scan, clean mergeability, and 11/11 GitHub checks passed.