Repository navigation
Improve task timeout handling - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskFuture.result()timeout errors.TaskWorker.stop()from blocking on already timed-out task threads.Pool.map()honormax_workers, preserve result order, and enforce bounded timeout behavior.Security changes
Usability changes
Pool.submit()andPool.map()now fail fast when task timeout expires.Pool.map(..., max_workers=...)now matches documented behavior for registered tasks.Tests/checks run
python -m pytest tests/test_compute/test_models.py::TestTaskFuture::test_result_timeout tests/test_compute/test_dispatch.py::TestDispatcherWorkerIntegration::test_worker_stop_returns_after_timed_out_task tests/test_compute/test_pool_compute.py::TestPoolSubmit::test_submit_timeout_is_enforced_for_registered_task -q— 3 passedpython -m pytest tests/test_compute/test_pool_compute.py -q— 19 passedpython -m pytest tests/test_compute/ -q— 109 passedmake lint— ruff passed; mypy passedmake test— 1023 passed, 2 warningsgit diff --check master...HEAD— cleanCommits
6073b41Harden task timeout handlinga533a68Honor registered task map parallelismf7958fcDocument task timeout behaviorRisks / manual review notes
Merge status
masterafter local validation, clean secret scan, clean mergeability check, and 11/11 passing GitHub Actions checks.