Skip to content

Bound network probe timeouts - #53

Merged
vikranthreddimasu merged 2 commits into
masterfrom
improve-network-probe-timeouts
Aug 2, 2026
Merged

vikranthreddimasu merged 2 commits into
masterfrom
improve-network-probe-timeouts

Conversation

@vikranthreddimasu

@vikranthreddimasu vikranthreddimasu commented Aug 2, 2026 •

Copy link
Copy Markdown
Owner
  • Summary: Validate latency and bandwidth probe inputs before socket work.
  • Summary: Apply one end-to-end timeout across connect, transfer, receiver acknowledgement, and cleanup.
  • Summary: Treat missing bandwidth receiver acknowledgement as probe failure instead of reporting fabricated throughput.
  • Security changes: None; authentication, authorization, credentials, TLS, and wire protocols are unchanged.
  • Usability changes: Invalid timeout and payload values now raise actionable ValueError messages; failed probes retain documented sentinel results.
  • Tests/checks run: python -m pytest tests/test_pool/test_network.py -q (33 passed).
  • Tests/checks run: make lint (Ruff passed; mypy passed across 55 source files).
  • Tests/checks run: make test (1051 passed, 3 skipped, 2 existing deprecation warnings).
  • Tests/checks run: wheel build, git diff --check, and diff-only secret scan passed.
  • Tests/checks run: All 11 GitHub Actions jobs passed.
  • Commit: 833668a Validate network probe inputs.
  • Commit: d58ff24 Bound network probe lifecycles.
  • Risks / manual review notes: Low-risk network utility change; timeout semantics are strictly end-to-end and unacknowledged bandwidth probes return 0.0.
  • Merge status: Merged into master after all checks passed.

@vikranthreddimasu
vikranthreddimasu merged commit 8dfb951 into master Aug 2, 2026
11 checks passed
@vikranthreddimasu
vikranthreddimasu deleted the improve-network-probe-timeouts branch August 2, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant