Repository navigation
Harden hardware exchange validation - #56
Open
vikranthreddimasu wants to merge 4 commits into
Open
vikranthreddimasu wants to merge 4 commits into
vikranthreddimasu wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HardwareExchangefields before accepting peer JSON.HandshakeHwValidationError.Security changes
Usability changes
Tests/checks run
make lintpassed: Ruff clean; mypy clean across 55 source files.git diff --checkpassed.Commits
de567afValidate peer hardware exchange fieldscff6798Reject invalid local hardware profilesb7cc326Reject malformed heartbeat hardware39d56d7Validate gossip hardware responsesRisks / manual review notes
Merge status