Added support for DSL Exists query to convert in RelNode format#1
Open
abhishek00159 wants to merge 3 commits intovinaykpud:feature/datafusion-dslfrom
Open
Added support for DSL Exists query to convert in RelNode format#1abhishek00159 wants to merge 3 commits intovinaykpud:feature/datafusion-dslfrom
abhishek00159 wants to merge 3 commits intovinaykpud:feature/datafusion-dslfrom
Conversation
This reverts commit 4ff57ed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the
QueryTranslatorinterface to convert OpenSearchExistsQueryBuilderto CalciteIS NOT NULLRexNode.1. Created ExistsQueryTranslator
Key Logic:
ExistsQueryBuilderIS NOT NULL($fieldIndex)RexNode using Calcite'sSqlStdOperatorTable.IS_NOT_NULLCalcite Output:
2. Registered ExistsQueryTranslator
File:
src/main/java/org/opensearch/dsl/query/QueryRegistryFactory.javaAdded registration in the
create()method:This makes the translator available for all exists queries.
3. Added Integration Tests
File:
src/internalClusterTest/java/org/opensearch/dsl/DslLogicalPlanIntegrationIT.javaAdded three comprehensive tests.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.