Event color by ehannes · Pull Request #19 · vinsol/fullcalendar-rails-engine

ehannes · 2014-11-24T15:25:16Z

Adds support for changing color of an event. An attribute "color" is added to the FullcalendarEngine::Event model. Fullcalendar already has this function, and this pull request enables it in this rails engine.

This pull request fixes #18

ehannes · 2015-01-14T06:46:19Z

Will you merge this pull request?

aditya-kapoor · 2015-01-14T06:56:19Z

why adding color to attr_accessor list when you are proposing it to be a column of the table?

I'm sorry, but I'm not sure what you mean. I would like the user to be able to set the color of an event. To do so, shouldn't the color be accessible through attr_accessor?

I am saying that you don't need to put it in the accessor list. It will always be accessible.

Okey. I'm pretty new to Rails. Would you mind telling me what's the difference from the title and the description that's in the attr_accessor?

title and description are added as accessors in event_series model so that they can be used to set the values for any event model using that value. See here
Since I don't see that you are setting the color of the event any where in the code, that's why I asked you to remove it.

You simply have to take care of the events create through the event_series part.
Just add another entry for color here.
And add a color picker as the input field in the form for event. You can learn more about color picker from here.

So I simply add it like this?

self.events.create( :title => title, :description => description, :all_day => all_day, :starttime => new_start_time, :endtime => new_end_time, :color => color )

Yes and add the color picker as input field in the form as I asked in one of my previous comments.

Do you know where to find such a color picker? How should you choose what color to pick?

Simply add f.color_field :name to the event form and you are done.

aditya-kapoor · 2015-04-04T18:59:25Z

hi @ehannes where do we stand on this?

ehannes · 2015-04-06T12:08:52Z

Hi!
Sorry that I've not been in touch. I used this plugin in a project that was ended in February. Fortunately, I will resume the work of that project in May then I will try to complete this pull request.

asadmoosa · 2015-05-21T18:59:03Z

That is what I've been looking for. What about adding user_id? User_id + color will be awesome. Can you please write a full project (Fullcalendar_engine + project) so that I can understand how values of color and user_id are added to MySQL. And how to retrieve calendar based on user_id + color.

ehannes · 2015-05-22T06:06:29Z

This pull request will unfortunately not, if I manage to finish it, include connection to user_id. It will only include the possibility to set the color of specific events in the calendar, a feature already available in Fullcalendar. Include user_id is, in my opinion, a totally different topic.

asadmoosa · 2015-06-30T00:19:09Z

Hannes, I totally agree with you that user_id is a different topic. I see that the color attribute is added to the gem. When i create a new project and Gemfile has that calendar gem and add a new model for user. How can the color of a speciic user be added to the event calendar?

ehannes · 2016-02-02T14:35:17Z

@aditya-kapoor: Took me nearly a year or so, but now I've added the color attribute to the strong parameters list and a color picker to the GUI :) Are we ready to merge now?

ehannes · 2016-03-16T10:20:49Z

@kuldeepaggarwal would you mind checking this PR as well?

kuldeepaggarwal · 2016-03-16T10:29:18Z

+        '#3B91AD' #default color
+      else
+        event.color 
+      end


can we extract default color to configuration, so that anyone can change the default as per their need?

a little code picking:

def set_event_color(event) event.color.presence || FullcalendarEngine.config.default_color end

Where would I include the default value? I had a look in config/initializers/configuration.rb, but if I understand it correctly, those values are passed to FullCalendar. The default_color value should not be passed to FullCalendar, right?

User should be able to create an initializer file, like devise.rb if you are aware about that. And he can set default values in that configuration file.

kuldeepaggarwal · 2016-03-22T15:54:14Z

@ehannes Any updates?

ehannes · 2016-03-22T16:34:45Z

@kuldeepaggarwal Not yet I'm afraid. I'm not sure how to implement the initializer file. Any links or tips about that?

kuldeepaggarwal · 2016-03-22T16:47:53Z

@ehannes We will implement that later, but could you please extract that logic to FullcalendarEngine::Configuration class and set default_color in that file and use FullcalendarEngine::Configuration.default_color

scout208 · 2016-03-25T17:20:53Z

We are using this gem for a project and we really want to use this feature. @ehannes do you have any idea when you might be finished? Or is there anything I can help with?

ehannes · 2016-04-03T16:03:22Z

Hi! Sorry for the delay.

@kuldeepaggarwal I gave it a try in 4bcc011. Was that what you meant? If not, please feel free to give further instructions. Otherwise I can push the branch to your repo so you can fix it.

@scout208 If we just get the default value for event color correct I think it's ready for merge.

kuldeepaggarwal · 2016-04-03T16:11:13Z

  'selectable'  => true,
-  'timeFormat'  => "h:mm t{ - h:mm t}"
+  'timeFormat'  => "h:mm t{ - h:mm t}",
+  'defaultColor' => '#3B91AD'


rename it to default_color.

All other variables in this config uses camelCase. Why should it use snake_case?

because all other variables are getting used on frontend, but if you just noticed at Line no: 18/19 we are using snake_case, as mount_path and default_color will be ruby realted variables.

I will think for a better implementation later.

Thanks for that clarification! I'll rename it then :)

kuldeepaggarwal · 2016-04-03T16:12:10Z

@ehannes Just fix above issues and then I think, we are good to go.

According to Ruby best practice, setter methods should not be prefixed with 'set'.

Ruby related variables should use snake_case instead of camelCase.

ehannes · 2016-04-03T16:24:45Z

I should probably add that I have not tested these changes. And I see that the test coverage of this engine is about 0%... I am using the engine in one of my own applications, but I haven't tested this specific branch.

kuldeepaggarwal · 2016-04-03T16:46:11Z

@ehannes Can you please test this in your app? It will be a great help.

ehannes · 2016-04-04T06:40:49Z

@kuldeepaggarwal Ok, I'll test it. Though, it would be advisable to add at least some basic tests to this engine.

kuldeepaggarwal · 2016-04-04T06:42:26Z

I agree that there must be test cases for the engine. Will plan something for this. Can you please create an issue for this on the repo?

Hannes Elvemyr added 2 commits November 24, 2014 14:37

Added color attribute to events

9adf030

Events default color same as fullcalendar's default

5ecd155

aditya-kapoor reviewed Jan 14, 2015
View reviewed changes

Keys symbolized in EventsController

e2b5251

Colors can now be set from GUI.

d2fc7e8

kuldeepaggarwal reviewed Mar 16, 2016
View reviewed changes

Default event color moved to config file

4bcc011

kuldeepaggarwal reviewed Apr 3, 2016
View reviewed changes

Hannes Elvemyr added 2 commits April 3, 2016 18:17

EventsController method set_event_color renamed

5fab077

According to Ruby best practice, setter methods should not be prefixed with 'set'.

defaultColor renamed to default_color

656c776

Ruby related variables should use snake_case instead of camelCase.

Conversation

ehannes commented Nov 24, 2014

Uh oh!

ehannes commented Jan 14, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aditya-kapoor commented Apr 4, 2015

Uh oh!

ehannes commented Apr 6, 2015

Uh oh!

asadmoosa commented May 21, 2015

Uh oh!

ehannes commented May 22, 2015

Uh oh!

asadmoosa commented Jun 30, 2015

Uh oh!

ehannes commented Feb 2, 2016

Uh oh!

ehannes commented Mar 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuldeepaggarwal commented Mar 22, 2016

Uh oh!

ehannes commented Mar 22, 2016

Uh oh!

kuldeepaggarwal commented Mar 22, 2016

Uh oh!

scout208 commented Mar 25, 2016

Uh oh!

ehannes commented Apr 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuldeepaggarwal commented Apr 3, 2016

Uh oh!

ehannes commented Apr 3, 2016

Uh oh!

kuldeepaggarwal commented Apr 3, 2016

Uh oh!

ehannes commented Apr 4, 2016

Uh oh!

kuldeepaggarwal commented Apr 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!