Removed unwanted CSS#32
Open
ehannes wants to merge 1 commit into
Open
Conversation
|
|
||
| h1{ | ||
| font-size: 16px; | ||
| } |
Contributor
There was a problem hiding this comment.
We can't do this straight away, as this may be possible that someone else is using the default css.
Contributor
Author
There was a problem hiding this comment.
That's the problem. Those rules should never have been included in the first place. Obviously, it is possible that someone is using that as default CSS. It is also possible that others (me included) do not want these CSS rules and has overwritten them (or forked the repo and removed them as I did).
The same goes for the rules for body, right?
You don't want to rely on an engine setting CSS rules. What should we do about it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine includes some unwanted CSS. This PR removes there CSS rules. See #16