Skip to content

fix: keep reference list item height consistent across states#1116

Merged
igboyes merged 1 commit into
mainfrom
igboyes/vir-2612-reference-list-item-height-differs-between-active-archived
Jul 8, 2026
Merged

fix: keep reference list item height consistent across states#1116
igboyes merged 1 commit into
mainfrom
igboyes/vir-2612-reference-list-item-height-differs-between-active-archived

Conversation

@igboyes

@igboyes igboyes commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Fixed reference list items visually jumping in height when toggling between active and archived states
  • Gave the trailing action area a fixed height so it no longer shrinks when its content is empty

@linear-code

linear-code Bot commented Jul 8, 2026

Copy link
Copy Markdown

VIR-2612

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider using a design token or shared size variable instead of the hardcoded h-10 so the trailing action area stays consistent with the rest of the design system if sizing changes.
  • If the end content can sometimes wrap or be taller than 40px, you might want to use a min-h-10 (or equivalent) rather than a fixed height to avoid clipping or layout issues in those edge cases.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider using a design token or shared size variable instead of the hardcoded `h-10` so the trailing action area stays consistent with the rest of the design system if sizing changes.
- If the `end` content can sometimes wrap or be taller than 40px, you might want to use a `min-h-10` (or equivalent) rather than a fixed height to avoid clipping or layout issues in those edge cases.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@igboyes igboyes merged commit ed57a2b into main Jul 8, 2026
10 checks passed
@igboyes igboyes deleted the igboyes/vir-2612-reference-list-item-height-differs-between-active-archived branch July 8, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant