fix: restore visible loading spinner animation#1118
Merged
igboyes merged 2 commits intoJul 8, 2026
Conversation
The Loader ring rendered as a uniform circle because tailwind-merge put border-b-transparent and the all-sides color class in the same border-color conflict group, dropping the transparent bottom. Emit per-side color classes (border-t/border-x) so the transparent bottom survives the merge. Also tighten the color prop to the shared six-color palette, fixing two call sites that passed unsupported values (white, primary) and silently fell back to gray.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that
Loader.coloris a narrowed union without a fallback, it might be worth adding a development-time safeguard (e.g.,satisfies Record<LoaderColor, string>or an exhaustive check) so future additions toLoaderColorcan’t accidentally be missed incolorToClass. - Consider extracting the color/class mapping used in the test into a shared constant (or reusing
colorToClass) so the test asserts behavior rather than duplicating the specific Tailwind class strings, making future palette changes less brittle.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that `Loader.color` is a narrowed union without a fallback, it might be worth adding a development-time safeguard (e.g., `satisfies Record<LoaderColor, string>` or an exhaustive check) so future additions to `LoaderColor` can’t accidentally be missed in `colorToClass`.
- Consider extracting the color/class mapping used in the test into a shared constant (or reusing `colorToClass`) so the test asserts behavior rather than duplicating the specific Tailwind class strings, making future palette changes less brittle.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Avoids duplicating the Tailwind class strings in the test so palette changes to Loader don't require updating hardcoded expectations.
Member
Author
|
Addressed in 2264bb4: On the exhaustiveness point: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loader'scolorprop to the shared six-color palette and fix two call sites passing unsupported values that were silently falling back to gray