Skip to content

refactor: remove dead index file uploaded_at and ready assignments#3640

Merged
igboyes merged 1 commit into
mainfrom
igboyes/vir-2608-remove-dead-uploaded_at-and-ready-assignments-in-index-file
Jul 7, 2026
Merged

refactor: remove dead index file uploaded_at and ready assignments#3640
igboyes merged 1 commit into
mainfrom
igboyes/vir-2608-remove-dead-uploaded_at-and-ready-assignments-in-index-file

Conversation

@igboyes

@igboyes igboyes commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Drop the uploaded_at and ready assignments in IndexData.upload_fileSQLIndexFile has no such columns, so they were set as orphan Python attributes that were never persisted or serialized.
  • No behaviour or response change; to_dict() already ignored them.

@linear-code

linear-code Bot commented Jul 7, 2026

Copy link
Copy Markdown

VIR-2608

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@igboyes igboyes merged commit 2891c86 into main Jul 7, 2026
9 checks passed
@igboyes igboyes deleted the igboyes/vir-2608-remove-dead-uploaded_at-and-ready-assignments-in-index-file branch July 7, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant