Skip to content

fix(widgets): restore Preact as JSX renderer, align with @deck.gl/widgets design #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlieforward9 merged 3 commits into from
Mar 5, 2026
Merged

fix(widgets): restore Preact as JSX renderer, align with @deck.gl/widgets design #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a7d620
Revert "refactor: remove preact dependency from widgets module"
charlieforward9 Mar 5, 2026
f0f42e9
fix(widgets): restore Preact as JSX renderer, fix deck.gl/core type c…
charlieforward9 Mar 5, 2026
5c2fa00
style: prettier format html-overlay-widget.tsx
charlieforward9 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/widgets/src/widgets/html-overlay-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// deck.gl-community
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors
/** @jsxImportSource preact */

import type {ComponentChildren, JSX} from 'preact';

Expand Down
4 changes: 2 additions & 2 deletions modules/widgets/src/widgets/html-overlay-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// deck.gl-community
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors
/** @jsxImportSource preact */

import {
cloneElement,
Expand Down Expand Up @@ -58,7 +59,6 @@ export class HtmlOverlayWidget<

placement: WidgetPlacement = 'fill';
className = 'deck-widget-html-overlay';
deck?: Deck | null = null;
protected viewport: Viewport | null = null;
protected overlayRoot: unknown = null;
protected overlayRootInitialized = false;
Expand All @@ -83,7 +83,7 @@ export class HtmlOverlayWidget<
}

override onRemove(): void {
this.deck = null;
this.deck = undefined;
this.viewport = null;
this.overlayRoot = null;
this.overlayRootInitialized = false;
Expand Down
1 change: 1 addition & 0 deletions modules/widgets/src/widgets/html-tooltip-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// deck.gl-community
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors
/** @jsxImportSource preact */

import type {ComponentChildren, VNode} from 'preact';
import type {PickingInfo, WidgetProps, Viewport} from '@deck.gl/core';
Expand Down
1 change: 1 addition & 0 deletions modules/widgets/src/widgets/long-press-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// deck.gl-community
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors
/** @jsxImportSource preact */

import {Component, type ComponentChildren} from 'preact';

Expand Down
5 changes: 3 additions & 2 deletions modules/widgets/src/widgets/pan-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// deck.gl-community
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors
/** @jsxImportSource preact */

import {render} from 'preact';
import type {JSX} from 'preact';
Expand Down Expand Up @@ -60,7 +61,7 @@ export class PanWidget extends Widget<PanWidgetProps> {

placement: WidgetPlacement = 'top-left';
className = 'deck-widget-pan';
deck?: Deck | null = null;

step: number;

constructor(props: PanWidgetProps = {}) {
Expand Down Expand Up @@ -91,7 +92,7 @@ export class PanWidget extends Widget<PanWidgetProps> {
}

override onRemove(): void {
this.deck = null;
this.deck = undefined;
}

override onRenderHTML(rootElement: HTMLElement): void {
Expand Down
2 changes: 1 addition & 1 deletion modules/widgets/src/widgets/view-manager-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export type DeckWithViewManager = Deck & {
};
};

export function hasViewManager(deck: Deck | null): deck is DeckWithViewManager {
export function hasViewManager(deck: Deck | null | undefined): deck is DeckWithViewManager {
return Boolean(deck && typeof deck === 'object' && 'viewManager' in deck);
}

Expand Down
5 changes: 3 additions & 2 deletions modules/widgets/src/widgets/zoom-range-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// deck.gl-community
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors
/** @jsxImportSource preact */

import {render} from 'preact';
import type {JSX} from 'preact';
Expand Down Expand Up @@ -75,7 +76,7 @@ export class ZoomRangeWidget extends Widget<ZoomRangeWidgetProps> {

placement: WidgetPlacement = 'top-left';
className = 'deck-widget-zoom-range';
deck?: Deck | null = null;

step: number;
currentZoom = 0;
inferredMinZoom: number | null = null;
Expand Down Expand Up @@ -109,7 +110,7 @@ export class ZoomRangeWidget extends Widget<ZoomRangeWidgetProps> {
}

override onRemove(): void {
this.deck = null;
this.deck = undefined;
}

override onRenderHTML(rootElement: HTMLElement): void {
Expand Down