chore: Update vf-hero component for optimised responsive image delivery and performance - #2443
Open
bhushan-ebi wants to merge 3 commits into
Open
chore: Update vf-hero component for optimised responsive image delivery and performance#2443bhushan-ebi wants to merge 3 commits into
bhushan-ebi wants to merge 3 commits into
Conversation
…ry and performance
…ry and performance
✅ Deploy Preview for tubular-strudel-7ad396 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sandykadam
reviewed
Aug 14, 2026
Comment on lines
+57
to
+59
| | Image Priority | `vf_hero_image_fetchpriority` | `vf-hero__image` | | ||
| | Image Loading | `vf_hero_image_loading` | `vf-hero__image` | | ||
| | Image Sizes | `vf_hero_image_sizes` | `vf-hero__image` | |
Collaborator
There was a problem hiding this comment.
Instead of asking users to pass multiple parameters, and you adding it in your code logic. Instead just use one parameter call it "extras" or some better name so users can combine and send it to that.
As there are tons of features cloudimg provides, please add documentation link as well if anybody want to tweak it - https://docs.cloudimage.io/transformations/image-operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.