Skip to content

feat(viewer): Copy prompt hands your waiting comments to an agent - #233

Open
onmax wants to merge 3 commits into
mainfrom
feat/review-copy-prompt
Open

onmax wants to merge 3 commits into
mainfrom
feat/review-copy-prompt

Conversation

@onmax

@onmax onmax commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Once you've left a comment on a drop, the pill shows Copy prompt on one track with Comments and the eye, since all three act on the comments. It steps aside while you comment, so the comment actions keep the pill to one row. It copies a prompt you can paste into an agent:

I left 2 comments on "Launch plan" in Drop. Resolve them.

https://drop.example.com/d/z19b3scpb2rz/launch-plan

1. The whole page
   Cut the intro to one line. (Ada)
2. > twelve servers
   Say which servers. (Ada)

If you have Drop's MCP server, call read_drop for drop z19b3scpb2rz for the current threads and anchors. Only if edits are still needed, publish the next version from the latest content with previous "z19b3scpb2rz" and a note saying what changed. Include in resolves only the still-open comments addressed by that publish from [1, 2]. Where words are the answer, use reply in the comment's thread instead. If you lack access or a tool is unavailable, prepare the proposed changes or answers for me instead.
  • Which comments: open threads where you spoke last. That covers comments you started and replies you left on someone else's. A thread someone answered after you, or one an agent wrote for you, drops out, and the button goes once none are left.
  • Self-contained: each comment carries its anchor, words, replies and image links, so an agent without Drop's MCP server can still start. The last paragraph names the MCP calls for the drop's kind, asks only for what the reader may do (a non-owner gets proposed changes, not a publish), and falls back to proposed changes when the agent has no Drop access. A site review's comments carry their element, box, and screenshot.
  • The "Copy feedback for your agent" button in the comments list still copies everyone's open comments.

Checked in headless Chromium on a local build: the button shows only once comments exist, and the click puts the text above on the clipboard. Unit tests cover which threads count and the wording per kind.

🤖 Generated with Claude Code

…, which hands your waiting comments to an agent

The prompt says how many comments you left and on which drop, lists each with its anchor, words, replies and images, and ends with the Drop MCP calls that resolve them: read_drop, then a new version with resolves (accept_suggestion first when there are suggestions), or reply with resolve: true on a site or a board. It counts open threads where you spoke last, so a thread someone answered, or one an agent wrote for you, drops out.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-18T10:57:18.836619Z
We couldn’t complete this review. Comment @codex review to try again.
09b50ac PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@onmax

onmax commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Before/after on Drop

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The copied prompt can ask agents to make changes Drop won't allow, and some feedback is missing from the handoff. Fix those cases before merging.

Approach: Reusing the viewer’s comments and Markdown formatter makes sense, but the generated actions need to match what the MCP tools can read, change, and resolve.

Reviewed changes — I traced the viewer’s copy action through thread selection, formatting, and the MCP handlers.

  • Viewer action: The review pill offers Copy prompt when qualifying threads exist; the comments panel retains its all-feedback copy action.
  • Thread selection: The last human message determines whether a thread is waiting on the current reader’s behalf, including follow-ups after resolution.
  • Agent handoff: The prompt includes numbered feedback and drop-specific tool instructions. All 58 existing feedback and MCP tests passed; seven temporary integration checks reproduced the cases below.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6.2-sol(high) | 𝕏

Comment thread app/utils/feedback.ts Resolved
Comment thread app/utils/feedback.ts Resolved
Comment thread app/utils/comment-threads.ts Resolved
Comment thread app/utils/feedback.ts Resolved
Comment thread app/utils/feedback.ts Resolved
@vite-hub

vite-hub Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor
Session Status Started Duration
View session Last seen running 2026-11-18T11:38:48.499Z 7s
View session Cancelled 2026-11-18T11:13:33.881Z 9m 9s

Queued

New pull request evidence is queued.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No P0 or P1 findings remain; one P2 issue with small screenshot annotations is noted inline.

Reviewed changes — Re-reviewed 6704816 against the previous review and ran the feedback, MCP tools, and site review suites. All 112 tests passed.

  • Aligned thread selection with the stored open status used by MCP.
  • Updated MCP guidance to match drop kind and reviewer permissions, and to publish again after accepting a suggestion only when edits remain.
  • Added screenshot context to site prompts and made the copy action wait while screenshot metadata is loading.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6.2-sol(high) | 𝕏

Comment thread app/utils/feedback.ts
function siteAnchor(comment: DropComment, screenshot: Screenshot | null, url: string) {
const { label, ox, oy, ow, oh } = comment
const element = label ? `\n Element \`${label}\`` : ""
const box = `\n Box ${pct(ox)}–${pct(ox + ow)} across, ${pct(oy)}–${pct(oy + oh)} down the ${screenshot ? "screenshot" : "viewport"}`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 — Class: coordinate rounding collapses small annotation boxes. A site screenshot box with ox: 100, oy: 200, ow: 3, and oh: 4 copies as 10%–10% across, 20%–20% down, so an agent sees a point instead of the area shown in Drop. Preserve tenths of a percent in siteAnchor so the copied box matches the screenshot overlay.

…he pill, and Copy prompt steps aside while you comment, so the pill keeps one row

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant