Skip to content

fix(vite): show an empty state for unrecorded modules - #636

Merged
antfu merged 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/unrecorded-vite-module
Nov 15, 2026
Merged

antfu merged 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/unrecorded-vite-module

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Open a module’s Imports tab and select a lazy dependency before the app requests it. Vite knows the dependency's ID, but has no recorded details for it yet. The panel shows a spinner indefinitely and hides its Close button.

- No module record → loading spinner
+ No module record → empty state with Close
  Module record available → module details with Close

Evidence

  • Before: In the Vite module graph, following main.js → Imports → details.js before the app loaded the dependency left the panel on “Loading” with no Close button.
  • After: In Chromium, following the same Imports path showed “No module details yet” and Close. The app made no request for details.js. Close returned to the graph. After reopening the panel and loading the dependency in the app, the panel showed its details without an inspector reload.

Lint, typecheck and build passed. The full test suite passed 412 tests with two skipped.

Merge Danger

Door: Two-way

Reverting restores the spinner for unrecorded modules.

Blast Radius: Details

The Vite module detail panel shows the empty state and its Close button.

@pkg-pr-new

pkg-pr-new Bot commented Nov 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@636

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@636

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@636

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@636

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@636

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@636

commit: c0dd707

@antfu
antfu merged commit 42288b5 into vitejs:main Nov 15, 2026
7 checks passed
@SaKaNa-Y
SaKaNa-Y deleted the fix/unrecorded-vite-module branch November 15, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants