Repository navigation
fix(vite): show an empty state for unrecorded modules - #636
Merged
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open a module’s Imports tab and select a lazy dependency before the app requests it. Vite knows the dependency's ID, but has no recorded details for it yet. The panel shows a spinner indefinitely and hides its Close button.
Evidence
main.js → Imports → details.jsbefore the app loaded the dependency left the panel on “Loading” with no Close button.details.js. Close returned to the graph. After reopening the panel and loading the dependency in the app, the panel showed its details without an inspector reload.Lint, typecheck and build passed. The full test suite passed 412 tests with two skipped.
Merge Danger
Door: Two-way
Reverting restores the spinner for unrecorded modules.
Blast Radius: Details
The Vite module detail panel shows the empty state and its Close button.