Repository navigation
fix(oxc): label the rule count by the rows shown - #637
Merged
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rules tab counts the rows that match its filters. The default list can include rules switched off by a category or override. Its badge labels every row enabled, so it can disagree with the enabled count on Overview.
Evidence
111 rules enabled.111 rules shown. The 109 disabled rules remained in the list.Lint, typecheck and build passed. The full test suite passed 412 tests with two skipped.
Merge Danger
Door: Two-way
Reverting restores the previous label.
Blast Radius: Badge
Only the count label on the Oxc Rules tab changes.