Skip to content

fix(oxc): label the rule count by the rows shown - #637

Merged
antfu merged 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/oxc-rule-count-label
Nov 15, 2026
Merged

antfu merged 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/oxc-rule-count-label

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The Rules tab counts the rows that match its filters. The default list can include rules switched off by a category or override. Its badge labels every row enabled, so it can disagree with the enabled count on Overview.

- 111 rules enabled
+ 111 rules shown

Evidence

  • Before: With 2 enabled rules and 109 disabled rules in the filtered list, rendering the Rules component produced 111 table rows and the badge 111 rules enabled.
  • After: Rendering the component with the same configuration produced the same 111 rows and the badge 111 rules shown. The 109 disabled rules remained in the list.

Lint, typecheck and build passed. The full test suite passed 412 tests with two skipped.

Merge Danger

Door: Two-way

Reverting restores the previous label.

Blast Radius: Badge

Only the count label on the Oxc Rules tab changes.

@pkg-pr-new

pkg-pr-new Bot commented Nov 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@637

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@637

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@637

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@637

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@637

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@637

commit: ff6997e

@antfu
antfu merged commit 4fc9b07 into vitejs:main Nov 15, 2026
7 checks passed
@SaKaNa-Y
SaKaNa-Y deleted the fix/oxc-rule-count-label branch November 15, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants