Skip to content

fix(ui): classify the built-in Vite resolver as a Vite plugin - #638

Merged
antfu merged 2 commits into
vitejs:mainfrom
SaKaNa-Y:fix/classify-vite-resolver
Nov 15, 2026
Merged

antfu merged 2 commits into
vitejs:mainfrom
SaKaNa-Y:fix/classify-vite-resolver

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The User Plugins filter can include Vite's built-in resolver. Both the Vite and Rolldown plugin pages use the same name-based filter. The resolver appears as rolldown:vite-resolve, so the existing vite: rule misses it.

- rolldown:vite-resolve → User Plugins
+ rolldown:vite-resolve → Vite

Evidence

  • Before: The shared classifier test expected vite for rolldown:vite-resolve and received plugin, the group displayed as User Plugins.
  • After: The test returned vite for the built-in resolver. It still returned the default plugin group for rolldown:vite-resolve-custom and rolldown:VITE-RESOLVE. All 10 tests in icon.test.ts passed.

Lint, typecheck and build passed. The full test suite passed 412 tests with two skipped.

Merge Danger

Door: Two-way

Reverting restores the previous plugin grouping.

Blast Radius: Filters

The Vite and Rolldown plugin pages use this rule to group the resolver in their filters.

@pkg-pr-new

pkg-pr-new Bot commented Nov 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@638

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@638

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@638

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@638

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@638

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@638

commit: 2630ead

@antfu
antfu merged commit f00fe8f into vitejs:main Nov 15, 2026
7 checks passed
@SaKaNa-Y
SaKaNa-Y deleted the fix/classify-vite-resolver branch November 15, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants