Repository navigation
fix(ui): classify the built-in Vite resolver as a Vite plugin - #638
Merged
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The User Plugins filter can include Vite's built-in resolver. Both the Vite and Rolldown plugin pages use the same name-based filter. The resolver appears as
rolldown:vite-resolve, so the existingvite:rule misses it.Evidence
viteforrolldown:vite-resolveand receivedplugin, the group displayed as User Plugins.vitefor the built-in resolver. It still returned the default plugin group forrolldown:vite-resolve-customandrolldown:VITE-RESOLVE. All 10 tests inicon.test.tspassed.Lint, typecheck and build passed. The full test suite passed 412 tests with two skipped.
Merge Danger
Door: Two-way
Reverting restores the previous plugin grouping.
Blast Radius: Filters
The Vite and Rolldown plugin pages use this rule to group the resolver in their filters.