Repository navigation
fix(ui): support keyboard selection in graph path pickers - #639
Merged
Merged
Conversation
SaKaNa-Y
marked this pull request as draft
November 13, 2026 14:33
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
Floating Vue can keep a menu open when the pointer moves toward it. Let the picker control the popup so Escape also dismisses it in that case.
Keep the selected endpoint on one line and let module candidates use their existing two-line layout. This keeps filenames visible when several paths share a long prefix.
SaKaNa-Y
marked this pull request as ready for review
November 17, 2026 12:16
Collaborator
Author
|
Fixed a bug that prevented users from selecting search results with the keyboard in the graph path picker. |
webfansplz
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Vite module graph and the Rolldown module and chunk graphs share a path picker. Keyboard users can search for a node but cannot select a visible match.
Escape closes the list. Changing the search returns the virtual list to its first match. After selection, focus moves to the clear button so Tab can continue to the next field.
Evidence
main.jsvisible in the candidate list, Arrow Down followed by Enter left the starting node empty. Clicking the same candidate selected it.node-30as Start andnode-70as End with the keyboard. Clearing Start reset both endpoints and returned focus to the Start field. After scrolling to the last option and searching again, clicking the first match selectednode-99. The build covered all three graph pages.Lint, typecheck and build passed. The full test suite passed 412 tests with two skipped.
Merge Danger
Door: Two-way
Reverting restores the previous path picker across all three graphs.
Blast Radius: Selection
The Vite module graph and the Rolldown module and chunk graphs share the picker. A focus or index error could select the wrong endpoint with the keyboard or pointer.