Repository navigation
Conversation
0froq
marked this pull request as draft
November 15, 2026 16:39
5 tasks done
0froq
force-pushed
the
fix/583-static-deploy-base
branch
from
November 18, 2026 13:55
0ea4983 to
9dc4510
Compare
0froq
marked this pull request as ready for review
November 18, 2026 14:07
0froq
force-pushed
the
fix/583-static-deploy-base
branch
from
November 18, 2026 14:18
9dc4510 to
9cc33a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass Vite's
basetobuildHubasdeployBase.@devframes/hub1.3.6 rebases frame bases, dock URLs, and the absolute references inside copied SPAs under that prefix, so a static snapshot works when served below the domain root. This PR forwards the option and bumps the devframe catalog to 1.3.6.Evidence
Ran the reproduction from #583 with the published
@devframes/hub@1.3.6and thedeployBaseline applied to its 0.8.2 core build:Serving
custom-dirat that path:A scan of every baked URL in the output's HTML, JS, CSS, and JSON found them all returning 200, with no root-absolute
"/__..."left.There is no new Vite-side test here. The rebasing lives in
@devframes/huband is covered by its build tests, and this PR forwards the option.Linked Issues
Fixes #583
Additional context
The devframe side is devframes/devframe#494, released as 1.3.6.