Skip to content

Add power and cadence#4

Merged
vitoksmile merged 3 commits intovitoksmile:mainfrom
jgillich:cycling
Nov 3, 2025
Merged

Add power and cadence#4
vitoksmile merged 3 commits intovitoksmile:mainfrom
jgillich:cycling

Conversation

@jgillich
Copy link
Copy Markdown
Contributor

Adds power and cadence metrics. Tested with Android (Health Connect, didn't bother with GFit). iOS has been filled in as best as I could, but I have no ability to test (only planning to get into iOS dev some time next year). Maybe I can do some CI-driven development to get it to build 😄

The naming is

  • Power -> HC Power / HK CyclingPower. HC's record used for any type of power meter, whereas HK is only for cycling. Doesn't seem like HK has support for other types of power meters (like rowers) at this time
  • PedalingCadence -> HC CyclingPedalingCadence / HK CyclingCadence. Might be better named CyclingCadence?

Power is stored as a double (watts). We could introduce a power unit type similar to Health Connect's API, but watts is probably all that 99.9% of people are ever going to need

@jgillich jgillich force-pushed the cycling branch 3 times, most recently from a2abdc4 to 835037f Compare October 31, 2025 16:49
@jgillich jgillich marked this pull request as ready for review October 31, 2025 16:57
@vitoksmile
Copy link
Copy Markdown
Owner

Hi @jgillich ,

Thank you for working on adding new data types.

Please take a look at comments, most of them are related to formatting and a-z ordering

@vitoksmile
Copy link
Copy Markdown
Owner

Power is stored as a double (watts). We could introduce a power unit type similar to Health Connect's API, but watts is probably all that 99.9% of people are ever going to need

My aim is to follow Health Connect and I would like to have same unit as Power for HealthKMP

@vitoksmile
Copy link
Copy Markdown
Owner

@jgillich please include new data types into README's section "Supported data types"

@vitoksmile
Copy link
Copy Markdown
Owner

@jgillich I am currenly working on adding new data types as well, please open new issue before considering adding more data types, so we don't step on each other's toes

@jgillich
Copy link
Copy Markdown
Contributor Author

Ok, I think I took care of everything.

@jgillich
Copy link
Copy Markdown
Contributor Author

Fwiw an automated formatter would make contributing much easier (alphabetical reordering aside)

@vitoksmile
Copy link
Copy Markdown
Owner

@jgillich thank you for spending time on resolving my comments

I will add some formatting tool to simplify the contribution process

@jgillich jgillich force-pushed the cycling branch 2 times, most recently from af8594c to 522c4ca Compare November 2, 2025 07:35
@jgillich jgillich force-pushed the cycling branch 2 times, most recently from e6d24f4 to 57611fa Compare November 2, 2025 07:49
@vitoksmile vitoksmile merged commit 55c3878 into vitoksmile:main Nov 3, 2025
2 checks passed
@vitoksmile
Copy link
Copy Markdown
Owner

@jgillich thank you for your work

I can confirm the iOS part works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants