Conversation
a2abdc4 to
835037f
Compare
health/src/commonMain/kotlin/com/viktormykhailiv/kmp/health/HealthDataType.kt
Outdated
Show resolved
Hide resolved
health/src/commonMain/kotlin/com/viktormykhailiv/kmp/health/records/PowerRecord.kt
Outdated
Show resolved
Hide resolved
health/src/commonMain/kotlin/com/viktormykhailiv/kmp/health/records/PowerRecord.kt
Show resolved
Hide resolved
health/src/commonMain/kotlin/com/viktormykhailiv/kmp/health/records/PowerRecord.kt
Show resolved
Hide resolved
health/src/androidMain/kotlin/com/viktormykhailiv/kmp/health/mapping.kt
Outdated
Show resolved
Hide resolved
health/src/androidMain/kotlin/com/viktormykhailiv/kmp/health/mapping.kt
Outdated
Show resolved
Hide resolved
health/src/androidMain/kotlin/com/viktormykhailiv/kmp/health/mapping.kt
Outdated
Show resolved
Hide resolved
health/src/appleMain/kotlin/com/viktormykhailiv/kmp/health/mapping.kt
Outdated
Show resolved
Hide resolved
health/src/appleMain/kotlin/com/viktormykhailiv/kmp/health/mapping.kt
Outdated
Show resolved
Hide resolved
|
Hi @jgillich , Thank you for working on adding new data types. Please take a look at comments, most of them are related to formatting and a-z ordering |
My aim is to follow Health Connect and I would like to have same unit as |
|
@jgillich please include new data types into README's section "Supported data types" |
|
@jgillich I am currenly working on adding new data types as well, please open new issue before considering adding more data types, so we don't step on each other's toes |
|
Ok, I think I took care of everything. |
|
Fwiw an automated formatter would make contributing much easier (alphabetical reordering aside) |
health/src/appleMain/kotlin/com/viktormykhailiv/kmp/health/HealthKitDataType.kt
Outdated
Show resolved
Hide resolved
health/src/appleMain/kotlin/com/viktormykhailiv/kmp/health/extensions.kt
Outdated
Show resolved
Hide resolved
health/src/appleMain/kotlin/com/viktormykhailiv/kmp/health/mapping.kt
Outdated
Show resolved
Hide resolved
health/src/commonMain/kotlin/com/viktormykhailiv/kmp/health/units/Power.kt
Show resolved
Hide resolved
|
@jgillich thank you for spending time on resolving my comments I will add some formatting tool to simplify the contribution process |
af8594c to
522c4ca
Compare
e6d24f4 to
57611fa
Compare
|
@jgillich thank you for your work I can confirm the iOS part works fine |
Adds power and cadence metrics. Tested with Android (Health Connect, didn't bother with GFit). iOS has been filled in as best as I could, but I have no ability to test (only planning to get into iOS dev some time next year). Maybe I can do some CI-driven development to get it to build 😄
The naming is
Power-> HCPower/ HKCyclingPower. HC's record used for any type of power meter, whereas HK is only for cycling. Doesn't seem like HK has support for other types of power meters (like rowers) at this timePedalingCadence-> HCCyclingPedalingCadence/ HKCyclingCadence. Might be better namedCyclingCadence?Power is stored as a double (watts). We could introduce a power unit type similar to Health Connect's API, but watts is probably all that 99.9% of people are ever going to need