Harden CI: pin conformance/install/handoff workflow actions to commit SHAs - #5279
Merged
Merged
Conversation
Pins all 20 action references in conformance-heartbeat.yml, install-test.yml and cross-repo-handoff.yml to full commit SHAs, keeping the human-readable version in a trailing comment so Dependabot still tracks them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pw5EDmCUvFQMXbdGXehQm9
✅ Drift Bot (ClawMetry): no drift detectedDrift Bot analyzed the changed files against this project's blueprints and requirements and found no drift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins all 20 action references in three workflow files to full commit SHAs, with the human-readable version kept in a trailing comment.
.github/workflows/conformance-heartbeat.yml.github/workflows/install-test.yml.github/workflows/cross-repo-handoff.ymlactions/checkout(11 refs)3d3c42e5aac5ba805825da76410c181273ba90b1# v7.0.1actions/setup-python(7 refs)5fda3b95a4ea91299a34e894583c3862153e4b97# v7.0.0actions/upload-artifact(2 refs)043fb46d1a93c77aae656e7c1c64a875d1fc6a0a# v7.0.1These are the same three digests already merged into
ci.ymlby #5275, so this adds no new trust decisions — it extends one already made.Why
A floating tag is resolved at run time, so whoever can move the tag decides what runs in CI. A digest cannot be moved. This is the OpenSSF Scorecard
PinnedDependenciesprobe.The trailing
# vX.Y.Zcomment is the form Dependabot reads, so version bumps keep flowing normally.Scope
One concern, three files, 20 insertions and 20 deletions — nothing else. No
permissions:blocks, job definitions or step logic are touched.These three files were chosen because every action in them is first-party (
actions/*) and already at the major version that the currently-open Dependabot bumps target, so pinning them now cannot conflict with those PRs. Files still holdingactions/upload-artifact@v4,actions/download-artifact@v4,azure/login@v2orsoftprops/action-gh-release@v2are deliberately left for after #5154, #5155, #5156 and #5157 land — pinning an old major there would collide with the bump.supply-chain.ymlis not touched; it is covered by the open PR #5276.Verification
python3 -c "import yaml,glob; [yaml.safe_load(open(f)) for f in glob.glob('.github/workflows/*.yml')]"→ OKpython3 scripts/check_action_refs.py→Found 22 distinct action reference(s) across the workflows. OKGenerated by Claude Code