Skip to content

Harden CI: stop the build and publish jobs persisting the job credential #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vivekchand merged 6 commits into from
Aug 30, 2026
Merged

Harden CI: stop the build and publish jobs persisting the job credential #5331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
735e88f
Harden CI: stop the build and publish jobs persisting the job credential
claude Aug 29, 2026
d8bdee0
Merge branch 'main' into harden/no-persisted-credentials-build-and-pu…
vivekchand Aug 29, 2026
2114415
Merge branch 'main' into harden/no-persisted-credentials-build-and-pu…
vivekchand Aug 29, 2026
c106689
Merge branch 'main' into harden/no-persisted-credentials-build-and-pu…
vivekchand Aug 29, 2026
8f5f28b
Merge branch 'main' into harden/no-persisted-credentials-build-and-pu…
vivekchand Aug 29, 2026
a569bdf
Merge branch 'main' into harden/no-persisted-credentials-build-and-pu…
vivekchand Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/auto-deploy-cloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ jobs:
steps:
- name: Checkout OSS repo
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
# Nothing in this job pushes from the OSS working copy -- every git
# command below runs after `cd clawmetry-cloud`, against the second
# checkout and its CLOUD_REPO_PAT. So this credential has no consumer
# and only stands in .git/config for the rest of the job. Do NOT copy
# this to the checkout below: that one's credential is the one the
# force-push uses.
persist-credentials: false

- name: Get OSS version
id: oss_version
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/desktop-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ jobs:
HAS_SIGN: ${{ secrets.MACOS_SIGN_IDENTITY != '' }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

# Same rule as the Windows job: signing is optional everywhere except
# a release tag. An unsigned .dmg is refused by Gatekeeper outright,
Expand Down Expand Up @@ -288,6 +290,8 @@ jobs:
HAS_WIN_CERT: ${{ secrets.WINDOWS_CERT_PFX_BASE64 != '' && !(secrets.AZURE_CLIENT_ID != '' && secrets.AZ_SIGN_PROFILE != '') }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
# A tag build that quietly produces an UNSIGNED artifact is worse
# than a failed build: it reaches users as "unknown publisher", and
# on Windows an unsigned uninstaller stub is blocked by Smart App
Expand Down Expand Up @@ -539,6 +543,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
python-version: "3.11"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/moat-keystone-drive-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ jobs:

steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
python-version: "3.11"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ jobs:

steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
Expand Down
Loading