Skip to content

fix(c6): remove_required_check handles checks array + fix tracking issue refs - #5931

Merged
vivekchand merged 1 commit into
mainfrom
fix/c6-remove-checks-array
Sep 13, 2026
Merged

fix(c6): remove_required_check handles checks array + fix tracking issue refs#5931
vivekchand merged 1 commit into
mainfrom
fix/c6-remove-checks-array

Conversation

@vivekchand

Copy link
Copy Markdown
Owner

Problem

remove_required_check in scripts/apply_required_status_checks.py only reads from the contexts array when checking whether a deprecated check is present. GitHub's Settings UI writes required checks to the checks array instead, so deprecated checks configured that way are permanently invisible to the removal path and never cleaned up.

If a deprecated check (e.g. OSS golden path (wheel + OpenClaw + 9 tabs)) was previously set via the Settings UI and is now in DEPRECATED_CHECKS, every run of the apply script would silently print "not present (clean), nothing to remove" and leave it in place.

This is a correctness bug in the C6 apply path, not a blocker for C6 itself (branch protection not yet configured), but it must be fixed before any admin run to ensure deprecated individual checks are actually cleaned up.

Changes

scripts/apply_required_status_checks.py

  • remove_required_check: now reads both contexts and checks arrays for the presence check, and includes the checks key in the PATCH body when the context is found there, so Settings-UI-configured deprecated checks are removed correctly
  • Updates two stale #4552 tracking references to the canonical #5266

Acceptance test

Run python3 -c "import importlib.util; ..." to verify the function signature is unchanged and the new body["checks"] path only activates when in_checks=True.

No-PRD: correctness fix in a script, not a product feature


🤖 Generated with Claude Code

https://claude.ai/code/session_01233ManZ6XTkXMc3QpfdVrV


Generated by Claude Code

Previously remove_required_check only read from the `contexts` array
when checking for a deprecated check, so a check configured via the
GitHub Settings UI (which writes to the `checks` array, not `contexts`)
would be silently skipped as "not present (clean)" and never removed.

Now reads both arrays for the presence check and includes the `checks`
key in the PATCH body when the context is found there, so Settings-UI-
configured deprecated checks are removed correctly.

Also updates two #4552 tracking references to the canonical #5266.

No-PRD: correctness fix in a script, not a product feature

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01233ManZ6XTkXMc3QpfdVrV
@8090-software-factory

Copy link
Copy Markdown

✅ Drift Bot (ClawMetry): no drift detected

Drift Bot analyzed the changed files against this project's blueprints and requirements and found no drift.

Copy link
Copy Markdown
Owner Author

CI failures here are not from this PR's changes.

This diff only modifies scripts/apply_required_status_checks.py (the remove_required_check function logic + two code comment references updated from #4552 to #5266). None of the failing checks (pip install (macos/ubuntu, py3.11), API Tests, E2E Browser Tests (critical subset), Eval Suite Gate, MOAT Keystone) are affected by changes to a utility script in scripts/.

The last CI run on main (commit 911b84aa, ~2h ago, #5929 merge) concluded success on these same checks. These failures are infrastructure flakes.

CI run is still in progress (some jobs queued). Will re-run failed jobs once the run completes.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

blocked on author decision — skipping (auto-mergeability sweep)

CI failures in the latest run (pip install, API Tests, MOAT, E2E) cannot be caused by the 1-file script change here (scripts/apply_required_status_checks.py). The same base SHA (911b84aa) was fully green ~2 h earlier on #5916 (06:40 UTC). Failures started at 08:51 UTC, suggesting a transient base-branch CI regression rather than code introduced by this PR. A fresh CI run after the base is repaired should turn this green.


Generated by Claude Code

@vivekchand
vivekchand merged commit 5a37b85 into main Sep 13, 2026
47 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants