Stage the xtask manifest in the release commit - #113
Merged
Conversation
`Auto bump` has failed on its last three runs — the two scheduled ones and a
dispatch — always at the same step, and always before anything was published.
`release.yml`'s version check rejected the candidate:
error: xtask/Cargo.toml internal dependency requirement is stale:
{ package = "rhei-plan", path = "../crates/rhei-core", version = "=0.3.0" }
`set-release-version.py` bumps that pin correctly; it goes out of its way to,
and its docstring says why: "`xtask` lives outside `crates/`, so a plain glob
there silently leaves its pins at the old version and the bump stops
resolving." The release commit then staged `crates/*/Cargo.toml` — the plain
glob that docstring warns about — so the bump was made in the working tree,
never committed, and the candidate branch carried the old pin.
Staging `xtask/Cargo.toml` beside it is the fix, with the reason written down
so the list is not trimmed back to the glob later.
Simulated both lists against a clone: the old one reproduces the error above
verbatim, the new one passes `verify-release-version.py`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto bumphas failed on its last three runs — 2026-08-17, 2026-08-24, and a dispatch today — always atrelease.yml'sVerify checked-in package versionsstep, and always before the publish step, so nothing was ever released and nothing was ever published in error.scripts/set-release-version.pybumps that pin correctly. It goes out of its way to, and its docstring says exactly why:The release commit in
auto-bump.ymlthen stagedCargo.toml crates/*/Cargo.toml Cargo.lock packages docs/changelog.md docs/changelog— the plain glob that docstring warns about. So the bump landed in the runner's working tree, was never committed, and the release-candidate branch carried the stale pin into the verifier.Fix is to stage
xtask/Cargo.tomlbeside the others, with the reason in a comment so the list is not trimmed back to the glob later.Verification
Simulated both staging lists in a clone — run the bump script, stage, commit, discard anything left unstaged the way a fresh CI checkout would, then run the verifier:
Two stale
release-candidate/v0.3.1-*branches are left on the remote from the failed runs; the cleanup only runs after a successful publish. Deleting them separately.🤖 Generated with Claude Code
https://claude.ai/code/session_01ANPWuKoibZ6NS84tJxeDC8