Name the poll budget in a re-spawn note instead of the unbounded sentinel - #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118
What changed
The re-spawn note on a poll state printed the internal
u64::MAXsentinel asif it were the attempt budget:
It now names the bound that actually applies,
poll.max_attempts:The poll state's exemption from the visit attempt budget is unchanged — the
poll's own exhaustion rule (
poll.max_attempts) is still the only thing thatends that loop — and a non-poll state's re-spawn note is byte-identical to
before.
resolve_attempt_budgetnow returns a typedAttemptBudget(Visit(u64)/Poll { max_attempts: u64 }) instead of encoding "exempt" asu64::MAX, andrespawn_noterenders each form accordingly.The spec sentence at
§FS-rhei-agents.3.2.1,a pinning integration test
(
run_poll_respawn_note_names_poll_max_attempts_not_the_sentinel), and thechangelog bullet are all in the same commit as the fix.