refactor: encapsulate struct fields and optimize network buffers#4
Merged
Conversation
added 3 commits
June 21, 2026 22:25
- Encapsulate User, Attendance, Finger, and ZKPacket fields to pub(crate) - Add public getters and constructors for encapsulated structs - Optimize TCP read calls using BufReader to prevent double syscalls - Configure UDP receive buffer size to 2MB to prevent packet loss - Refactor all unit and integration tests to use new getters and constructors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: encapsulate struct fields and optimize network buffers