refactor: resolve top 5 critical technical debts#5
Merged
Conversation
added 6 commits
June 22, 2026 00:12
…psulation, optimize transport memory
…ut, non-blocking Drop, TCP desync recovery, structured error helpers, and zero-alloc ACK payload
…hecksum validation, OOM protection, DRY user models, heap optimization)
- attendance.rs: Enforce strict record size validation (8, 16, 40) - transport.rs: Close & clear TCP socket on errors/timeouts to prevent desync - models.rs & device.rs: Handle ambiguous/fold Chrono LocalResult for DST transitions - lib.rs & transport.rs: Send non-blocking CMD_EXIT on Drop to prevent session leaks - protocol.rs: Auto-skip checksum bytes (2-3) on raw packets for calculate_checksum - tests: Added comprehensive integration/unit tests to verify all safety fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: resolve top 5 critical technical debts